]> git.proxmox.com Git - mirror_qemu.git/commitdiff
lm32: milkymist-tmu2: fix integer overflow
authorMichael Walle <michael@walle.cc>
Wed, 12 Oct 2016 22:35:07 +0000 (00:35 +0200)
committerMichael Tokarev <mjt@tls.msk.ru>
Fri, 28 Oct 2016 15:17:23 +0000 (18:17 +0300)
Don't truncate the multiplication and do a 64 bit one instead because
because the result is stored in a 64 bit variable.

Spotted by coverity, CID 1167561.

Signed-off-by: Michael Walle <michael@walle.cc>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
hw/display/milkymist-tmu2.c

index 9c0018448a63f3a40bdc53bc2b5d977c4dc47a91..5c666f9b242bf1c6fab97cbaa57a866abba6cdf4 100644 (file)
@@ -213,7 +213,7 @@ static void tmu2_start(MilkymistTMU2State *s)
     /* Read the QEMU source framebuffer into an OpenGL texture */
     glGenTextures(1, &texture);
     glBindTexture(GL_TEXTURE_2D, texture);
-    fb_len = 2*s->regs[R_TEXHRES]*s->regs[R_TEXVRES];
+    fb_len = 2ULL * s->regs[R_TEXHRES] * s->regs[R_TEXVRES];
     fb = cpu_physical_memory_map(s->regs[R_TEXFBUF], &fb_len, 0);
     if (fb == NULL) {
         glDeleteTextures(1, &texture);