]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
qmi_wwan: set FLAG_SEND_ZLP to avoid network initiated disconnect
authorBjørn Mork <bjorn@mork.no>
Thu, 14 Dec 2017 18:55:50 +0000 (19:55 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 15 Dec 2017 18:50:13 +0000 (13:50 -0500)
It has been reported that the dummy byte we add to avoid
ZLPs can be forwarded by the modem to the PGW/GGSN, and that
some operators will drop the connection if this happens.

In theory, QMI devices are based on CDC ECM and should as such
both support ZLPs and silently ignore the dummy byte.  The latter
assumption failed.  Let's test out the first.

Signed-off-by: Bjørn Mork <bjorn@mork.no>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/qmi_wwan.c

index 304ec6555cd88b3b058b944f6120df3294adb1ca..1ed00519f29ecd3ba34e31a4c286452e69b124fa 100644 (file)
@@ -826,7 +826,7 @@ err:
 
 static const struct driver_info        qmi_wwan_info = {
        .description    = "WWAN/QMI device",
-       .flags          = FLAG_WWAN,
+       .flags          = FLAG_WWAN | FLAG_SEND_ZLP,
        .bind           = qmi_wwan_bind,
        .unbind         = qmi_wwan_unbind,
        .manage_power   = qmi_wwan_manage_power,
@@ -835,7 +835,7 @@ static const struct driver_info     qmi_wwan_info = {
 
 static const struct driver_info        qmi_wwan_info_quirk_dtr = {
        .description    = "WWAN/QMI device",
-       .flags          = FLAG_WWAN,
+       .flags          = FLAG_WWAN | FLAG_SEND_ZLP,
        .bind           = qmi_wwan_bind,
        .unbind         = qmi_wwan_unbind,
        .manage_power   = qmi_wwan_manage_power,