]> git.proxmox.com Git - qemu.git/commitdiff
slirp: check system() success
authorJuan Quintela <quintela@redhat.com>
Thu, 4 Mar 2010 09:00:31 +0000 (10:00 +0100)
committerAnthony Liguori <aliguori@us.ibm.com>
Tue, 9 Mar 2010 17:23:00 +0000 (11:23 -0600)
we shouldn't call W*() macros until we check that fork worked.

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
net/slirp.c

index 317cca7f63f2598703c04ba2a97f16f6f358ae4a..7f846ec6f9e6fc95923d61c867003ea659700393 100644 (file)
@@ -472,7 +472,7 @@ static void slirp_smb_cleanup(SlirpState *s)
     if (s->smb_dir[0] != '\0') {
         snprintf(cmd, sizeof(cmd), "rm -rf %s", s->smb_dir);
         ret = system(cmd);
-        if (!WIFEXITED(ret)) {
+        if (ret == -1 || !WIFEXITED(ret)) {
             qemu_error("'%s' failed.\n", cmd);
         } else if (WEXITSTATUS(ret)) {
             qemu_error("'%s' failed. Error code: %d\n",