]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
fbdev/radeon: use pci aperture helpers
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 11 Jan 2023 15:41:08 +0000 (16:41 +0100)
committerStefan Bader <stefan.bader@canonical.com>
Mon, 30 Oct 2023 11:00:22 +0000 (12:00 +0100)
BugLink: https://bugs.launchpad.net/bugs/2039742
[ Upstream commit 9b539c4d1b921bc9c8c578d4d50f0a7e7874d384 ]

It's not exactly the same since the open coded version doesn't set
primary correctly. But that's a bugfix, so shouldn't hurt really.

Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-fbdev@vger.kernel.org
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230111154112.90575-7-daniel.vetter@ffwll.ch
Stable-dep-of: 5ae3716cfdcd ("video/aperture: Only remove sysfb on the default vga pci device")
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/video/fbdev/aty/radeon_base.c

index 1cf2d14af380d3205f56d088f85657fec597e463..972c4bbedfa36291b3514db77497fb0f6e97b7cd 100644 (file)
@@ -2238,14 +2238,6 @@ static const struct bin_attribute edid2_attr = {
        .read   = radeon_show_edid2,
 };
 
-static int radeon_kick_out_firmware_fb(struct pci_dev *pdev)
-{
-       resource_size_t base = pci_resource_start(pdev, 0);
-       resource_size_t size = pci_resource_len(pdev, 0);
-
-       return aperture_remove_conflicting_devices(base, size, KBUILD_MODNAME);
-}
-
 static int radeonfb_pci_register(struct pci_dev *pdev,
                                 const struct pci_device_id *ent)
 {
@@ -2296,7 +2288,7 @@ static int radeonfb_pci_register(struct pci_dev *pdev,
        rinfo->fb_base_phys = pci_resource_start (pdev, 0);
        rinfo->mmio_base_phys = pci_resource_start (pdev, 2);
 
-       ret = radeon_kick_out_firmware_fb(pdev);
+       ret = aperture_remove_conflicting_pci_devices(pdev, KBUILD_MODNAME);
        if (ret)
                goto err_release_fb;