]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
media: coda: Fix missing put_device() call in coda_get_vdoa_data
authorMiaoqian Lin <linmq006@gmail.com>
Wed, 12 Jan 2022 11:05:54 +0000 (12:05 +0100)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 20 May 2022 12:38:11 +0000 (14:38 +0200)
BugLink: https://bugs.launchpad.net/bugs/1969110
[ Upstream commit ca85d271531a1e1c86f24b892f57b7d0a3ddb5a6 ]

The reference taken by 'of_find_device_by_node()' must be released when
not needed anymore.
Add the corresponding 'put_device()' in the error handling path.

Fixes: e7f3c5481035 ("[media] coda: use VDOA for un-tiling custom macroblock format")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
(cherry picked from commit c3590ec1161d2178bfba0155bb0dc2d29dffbc4e)
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/media/platform/coda/coda-common.c

index 9a2640a9c75c6e5b4b63caad9106d2af9ac9fbf3..4a553f42ff0a348d9c5d44762e80441c3d19e7fe 100644 (file)
@@ -408,6 +408,7 @@ static struct vdoa_data *coda_get_vdoa_data(void)
        if (!vdoa_data)
                vdoa_data = ERR_PTR(-EPROBE_DEFER);
 
+       put_device(&vdoa_pdev->dev);
 out:
        of_node_put(vdoa_node);