]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
RDMA/siw: Fix setting active_{speed, width} attributes
authorKamal Heib <kamalheib1@gmail.com>
Tue, 18 Feb 2020 09:59:11 +0000 (11:59 +0200)
committerJason Gunthorpe <jgg@mellanox.com>
Thu, 27 Feb 2020 20:40:40 +0000 (16:40 -0400)
Make sure to set the active_{speed, width} attributes to avoid reporting
the same values regardless of the underlying device.

Fixes: 303ae1cdfdf7 ("rdma/siw: application interface")
Link: https://lore.kernel.org/r/20200218095911.26614-1-kamalheib1@gmail.com
Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
Tested-by: Bernard Metzler <bmt@zurich.ibm.com>
Reviewed-by: Bernard Metzler <bmt@zurich.ibm.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/sw/siw/siw_verbs.c

index 73485d0da907dbb51b89861185bc6463862d83ef..d5390d498c61dfdd9cd08914216a0962b29617c0 100644 (file)
@@ -165,11 +165,12 @@ int siw_query_port(struct ib_device *base_dev, u8 port,
                   struct ib_port_attr *attr)
 {
        struct siw_device *sdev = to_siw_dev(base_dev);
+       int rv;
 
        memset(attr, 0, sizeof(*attr));
 
-       attr->active_speed = 2;
-       attr->active_width = 2;
+       rv = ib_get_eth_speed(base_dev, port, &attr->active_speed,
+                        &attr->active_width);
        attr->gid_tbl_len = 1;
        attr->max_msg_sz = -1;
        attr->max_mtu = ib_mtu_int_to_enum(sdev->netdev->mtu);
@@ -192,7 +193,7 @@ int siw_query_port(struct ib_device *base_dev, u8 port,
         * attr->subnet_timeout = 0;
         * attr->init_type_repy = 0;
         */
-       return 0;
+       return rv;
 }
 
 int siw_get_port_immutable(struct ib_device *base_dev, u8 port,