printk: fix exclusive_console replaying

BugLink: https://bugs.launchpad.net/bugs/1866678
[ Upstream commit def97da136515cb289a14729292c193e0a93bc64 ]

Commit f92b070f2dc8 ("printk: Do not miss new messages when replaying
the log") introduced a new variable @exclusive_console_stop_seq to
store when an exclusive console should stop printing. It should be
set to the @console_seq value at registration. However, @console_seq
is previously set to @syslog_seq so that the exclusive console knows
where to begin. This results in the exclusive console immediately
reactivating all the other consoles and thus repeating the messages
for those consoles.

Set @console_seq after @exclusive_console_stop_seq has stored the
current @console_seq value.

Fixes: f92b070f2dc8 ("printk: Do not miss new messages when replaying the log")
Link: http://lkml.kernel.org/r/20191219115322.31160-1-john.ogness@linutronix.de
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: John Ogness <john.ogness@linutronix.de>
Acked-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Signed-off-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>

diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index 465b5f111c24d9c40dc2653a84bf61c48cf0a3f5..8c86e6a9ee97ec69c136e63424a4ff2dbc70613e 100644 (file)
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -2703,8 +2703,6 @@ void register_console(struct console *newcon)
                 * for us.
                 */
                logbuf_lock_irqsave(flags);
-               console_seq = syslog_seq;
-               console_idx = syslog_idx;
                /*
                 * We're about to replay the log buffer.  Only do this to the
                 * just-registered console to avoid excessive message spam to
@@ -2716,6 +2714,8 @@ void register_console(struct console *newcon)
                 */
                exclusive_console = newcon;
                exclusive_console_stop_seq = console_seq;
+               console_seq = syslog_seq;
+               console_idx = syslog_idx;
                logbuf_unlock_irqrestore(flags);
        }
        console_unlock();