]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
mxser: remove xmit_cnt < 0 tests
authorJiri Slaby <jslaby@suse.cz>
Fri, 18 Jun 2021 06:15:06 +0000 (08:15 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 18 Jun 2021 11:10:02 +0000 (13:10 +0200)
mxser_port::xmit_cnt is unsigned, it cannot be negative. Therefore
remove all the xmit_cnt < 0 tests.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Link: https://lore.kernel.org/r/20210618061516.662-61-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/mxser.c

index e46974e9421a44d83a8a95866c58967fc1df8986..1a8698e58b1cf03a8a3abee5a88434e6dbb9845c 100644 (file)
@@ -995,7 +995,7 @@ static void mxser_flush_chars(struct tty_struct *tty)
 {
        struct mxser_port *info = tty->driver_data;
 
-       if (info->xmit_cnt <= 0 || tty->flow.stopped || !info->port.xmit_buf ||
+       if (!info->xmit_cnt || tty->flow.stopped || !info->port.xmit_buf ||
                        (tty->hw_stopped && info->type != PORT_16550A &&
                         !info->board->must_hwid))
                return;
@@ -1652,7 +1652,7 @@ static void mxser_transmit_chars(struct tty_struct *tty, struct mxser_port *port
        if (port->port.xmit_buf == NULL)
                return;
 
-       if (port->xmit_cnt <= 0 || tty->flow.stopped ||
+       if (!port->xmit_cnt || tty->flow.stopped ||
                        (tty->hw_stopped &&
                        (port->type != PORT_16550A) &&
                        (!port->board->must_hwid))) {
@@ -1666,7 +1666,7 @@ static void mxser_transmit_chars(struct tty_struct *tty, struct mxser_port *port
                outb(port->port.xmit_buf[port->xmit_tail++],
                        port->ioaddr + UART_TX);
                port->xmit_tail = port->xmit_tail & (SERIAL_XMIT_SIZE - 1);
-               if (--port->xmit_cnt <= 0)
+               if (!--port->xmit_cnt)
                        break;
        } while (--count > 0);
 
@@ -1675,7 +1675,7 @@ static void mxser_transmit_chars(struct tty_struct *tty, struct mxser_port *port
        if (port->xmit_cnt < WAKEUP_CHARS)
                tty_wakeup(tty);
 
-       if (port->xmit_cnt <= 0)
+       if (!port->xmit_cnt)
                __mxser_stop_tx(port);
 }