]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
ibmvnic: remove unnecessary rmb() inside ibmvnic_poll
authorLijun Pan <ljp@linux.ibm.com>
Sat, 30 Jan 2021 01:19:05 +0000 (19:19 -0600)
committerJakub Kicinski <kuba@kernel.org>
Tue, 2 Feb 2021 04:21:12 +0000 (20:21 -0800)
rmb() can be removed since:
1. pending_scrq() has dma_rmb() at the function end;
2. dma_rmb(), though weaker, is enough here.

Signed-off-by: Lijun Pan <ljp@linux.ibm.com>
Acked-by: Dwip Banerjee <dnbanerg@us.ibm.com>
Acked-by: Thomas Falcon <tlfalcon@linux.ibm.com>
Reviewed-by: Brian King <brking@linux.vnet.ibm.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/ibm/ibmvnic.c

index 331ebca2f57a2164aba183d93fb049b9c464cb0b..0ed169ef1cfcb83915d5610da9a9d8054459e8ae 100644 (file)
@@ -2510,7 +2510,6 @@ restart_poll:
                if (napi_complete_done(napi, frames_processed)) {
                        enable_scrq_irq(adapter, rx_scrq);
                        if (pending_scrq(adapter, rx_scrq)) {
-                               rmb();
                                if (napi_reschedule(napi)) {
                                        disable_scrq_irq(adapter, rx_scrq);
                                        goto restart_poll;