]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
drm/ssd130x: Fix pitch calculation in ssd130x_fb_blit_rect()
authorGeert Uytterhoeven <geert@linux-m68k.org>
Thu, 13 Jul 2023 13:17:09 +0000 (15:17 +0200)
committerJavier Martinez Canillas <javierm@redhat.com>
Fri, 21 Jul 2023 22:33:49 +0000 (00:33 +0200)
The page height must be taken into account only for vertical coordinates
and heights, not for horizontal coordinates and widths.

Fixes: 179a790aaf2a ("drm/ssd130x: Set the page height value in the device info data")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/54deec2ec533e90544faa8c60a0c2518c58f3e9c.1689252746.git.geert@linux-m68k.org
drivers/gpu/drm/solomon/ssd130x.c

index afb08a8aa9fcdaf2d4350d1a33130b7fa9ad5ba4..b4c376962629580be0b4ca6aa36872ccc8a0313a 100644 (file)
@@ -596,7 +596,7 @@ static int ssd130x_fb_blit_rect(struct drm_framebuffer *fb, const struct iosys_m
        rect->y1 = round_down(rect->y1, page_height);
        rect->y2 = min_t(unsigned int, round_up(rect->y2, page_height), ssd130x->height);
 
-       dst_pitch = DIV_ROUND_UP(drm_rect_width(rect), page_height);
+       dst_pitch = DIV_ROUND_UP(drm_rect_width(rect), 8);
 
        ret = drm_gem_fb_begin_cpu_access(fb, DMA_FROM_DEVICE);
        if (ret)