]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
drm/i915/display: Do not re-enable PSR after it was marked as not reliable
authorJosé Roberto de Souza <jose.souza@intel.com>
Fri, 11 Mar 2022 18:51:49 +0000 (10:51 -0800)
committerJoonas Lahtinen <joonas.lahtinen@linux.intel.com>
Wed, 16 Mar 2022 06:17:40 +0000 (08:17 +0200)
If a error happens and sink_not_reliable is set, PSR should be disabled
for good but that is not happening.
It would be disabled by the function handling the PSR error but then
on the next fastset it would be enabled again in
_intel_psr_post_plane_update().
It would only be disabled for good in the next modeset where has_psr
will be set false.

v2:
- release psr lock before continue

Fixes: 9ce5884e5139 ("drm/i915/display: Only keep PSR enabled if there is active planes")
Reported-by: Khaled Almahallawy <khaled.almahallawy@intel.com>
Reported-by: Charlton Lin <charlton.lin@intel.com>
Cc: Jouni Högander <jouni.hogander@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220311185149.110527-2-jose.souza@intel.com
(cherry picked from commit 15f26bdc81f7f03561aaea5a10d87bd6638e1459)
Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
drivers/gpu/drm/i915/display/intel_psr.c

index 2e0b092f4b6be52ca0ed5cfb73a4aaeb90a5439f..5895b89df03a1cac9573f1040ce918954d473015 100644 (file)
@@ -1837,6 +1837,9 @@ static void _intel_psr_post_plane_update(const struct intel_atomic_state *state,
 
                mutex_lock(&psr->lock);
 
+               if (psr->sink_not_reliable)
+                       goto exit;
+
                drm_WARN_ON(&dev_priv->drm, psr->enabled && !crtc_state->active_planes);
 
                /* Only enable if there is active planes */
@@ -1847,6 +1850,7 @@ static void _intel_psr_post_plane_update(const struct intel_atomic_state *state,
                if (crtc_state->crc_enabled && psr->enabled)
                        psr_force_hw_tracking_exit(intel_dp);
 
+exit:
                mutex_unlock(&psr->lock);
        }
 }