]> git.proxmox.com Git - mirror_qemu.git/commitdiff
tests: Remove FIXME comments
authorKevin Wolf <kwolf@redhat.com>
Thu, 9 Feb 2017 14:48:04 +0000 (15:48 +0100)
committerKevin Wolf <kwolf@redhat.com>
Tue, 28 Feb 2017 19:47:50 +0000 (20:47 +0100)
Not requesting any permissions is actually correct for these test cases
because no actual I/O or other operation covered by the permission
system is performed.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Acked-by: Fam Zheng <famz@redhat.com>
tests/test-blockjob.c
tests/test-throttle.c

index 1afe17b4498df1dea3fd2c1e64a9679623201179..740e740398ece2fb9d43d351b3afceacdbd2dafc 100644 (file)
@@ -54,7 +54,7 @@ static BlockJob *do_test_id(BlockBackend *blk, const char *id,
  * BlockDriverState inserted. */
 static BlockBackend *create_blk(const char *name)
 {
-    /* FIXME Use real permissions */
+    /* No I/O is performed on this device */
     BlockBackend *blk = blk_new(0, BLK_PERM_ALL);
     BlockDriverState *bs;
 
index 5846433c9f85ca01b8c61a83759464bd509c6c3c..bd7c501b2e5c351644735acf13a9bad4b43e222c 100644 (file)
@@ -593,7 +593,7 @@ static void test_groups(void)
     BlockBackend *blk1, *blk2, *blk3;
     BlockBackendPublic *blkp1, *blkp2, *blkp3;
 
-    /* FIXME Use real permissions */
+    /* No actual I/O is performed on these devices */
     blk1 = blk_new(0, BLK_PERM_ALL);
     blk2 = blk_new(0, BLK_PERM_ALL);
     blk3 = blk_new(0, BLK_PERM_ALL);