]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
x86/entry: __always_inline CR2 for noinstr
authorPeter Zijlstra <peterz@infradead.org>
Wed, 3 Jun 2020 11:40:22 +0000 (13:40 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Thu, 11 Jun 2020 13:15:28 +0000 (15:15 +0200)
vmlinux.o: warning: objtool: exc_page_fault()+0x9: call to read_cr2() leaves .noinstr.text section
vmlinux.o: warning: objtool: exc_page_fault()+0x24: call to prefetchw() leaves .noinstr.text section
vmlinux.o: warning: objtool: exc_page_fault()+0x21: call to kvm_handle_async_pf.isra.0() leaves .noinstr.text section
vmlinux.o: warning: objtool: exc_nmi()+0x1cc: call to write_cr2() leaves .noinstr.text section

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/20200603114052.243227806@infradead.org
arch/x86/include/asm/kvm_para.h
arch/x86/include/asm/processor.h
arch/x86/include/asm/special_insns.h

index 57fd1966c4ea9a4063215e8d1d2f0690b7681066..49d3a9edb06f64947ee8d6c20b860aed50f068b5 100644 (file)
@@ -141,7 +141,7 @@ static inline void kvm_disable_steal_time(void)
        return;
 }
 
-static inline bool kvm_handle_async_pf(struct pt_regs *regs, u32 token)
+static __always_inline bool kvm_handle_async_pf(struct pt_regs *regs, u32 token)
 {
        return false;
 }
index 29ee0c088009d026d0059f2a983283eb332e5ec5..42cd333616c487b5730bfd909660784f0f231981 100644 (file)
@@ -823,7 +823,7 @@ static inline void prefetch(const void *x)
  * Useful for spinlocks to avoid one state transition in the
  * cache coherency protocol:
  */
-static inline void prefetchw(const void *x)
+static __always_inline void prefetchw(const void *x)
 {
        alternative_input(BASE_PREFETCH, "prefetchw %P1",
                          X86_FEATURE_3DNOWPREFETCH,
index 82436cb04ccf5f0635b743dc2bff69d002c66554..eb8e781c4353946f0dd4aca6363a88411896ea2c 100644 (file)
@@ -28,14 +28,14 @@ static inline unsigned long native_read_cr0(void)
        return val;
 }
 
-static inline unsigned long native_read_cr2(void)
+static __always_inline unsigned long native_read_cr2(void)
 {
        unsigned long val;
        asm volatile("mov %%cr2,%0\n\t" : "=r" (val), "=m" (__force_order));
        return val;
 }
 
-static inline void native_write_cr2(unsigned long val)
+static __always_inline void native_write_cr2(unsigned long val)
 {
        asm volatile("mov %0,%%cr2": : "r" (val), "m" (__force_order));
 }
@@ -160,12 +160,12 @@ static inline void write_cr0(unsigned long x)
        native_write_cr0(x);
 }
 
-static inline unsigned long read_cr2(void)
+static __always_inline unsigned long read_cr2(void)
 {
        return native_read_cr2();
 }
 
-static inline void write_cr2(unsigned long x)
+static __always_inline void write_cr2(unsigned long x)
 {
        native_write_cr2(x);
 }