KVM: arm64: Handle PSCI resets before userspace touches vCPU state

BugLink: https://bugs.launchpad.net/bugs/1948873
[ Upstream commit 6826c6849b46aaa91300201213701eb861af4ba0 ]

The CPU_ON PSCI call takes a payload that KVM uses to configure a
destination vCPU to run. This payload is non-architectural state and not
exposed through any existing UAPI. Effectively, we have a race between
CPU_ON and userspace saving/restoring a guest: if the target vCPU isn't
ran again before the VMM saves its state, the requested PC and context
ID are lost. When restored, the target vCPU will be runnable and start
executing at its old PC.

We can avoid this race by making sure the reset payload is serviced
before userspace can access a vCPU's state.

Fixes: 358b28f09f0a ("arm/arm64: KVM: Allow a VCPU to fully reset itself")
Signed-off-by: Oliver Upton <oupton@google.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20210818202133.1106786-3-oupton@google.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>

diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c
index a26aaa63e56e7cc6896ef9ed89dd99a62f231fbc..5a6fe5f6dda20b2d5e0fe9f6071d64f821511627 100644 (file)
--- a/arch/arm64/kvm/arm.c
+++ b/arch/arm64/kvm/arm.c
@@ -1189,6 +1189,14 @@ long kvm_arch_vcpu_ioctl(struct file *filp,
                if (copy_from_user(&reg, argp, sizeof(reg)))
                        break;
 
+               /*
+                * We could owe a reset due to PSCI. Handle the pending reset
+                * here to ensure userspace register accesses are ordered after
+                * the reset.
+                */
+               if (kvm_check_request(KVM_REQ_VCPU_RESET, vcpu))
+                       kvm_reset_vcpu(vcpu);
+
                if (ioctl == KVM_SET_ONE_REG)
                        r = kvm_arm_set_reg(vcpu, &reg);
                else