]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
net: phy: mdio-bcm-unimac: fix potential NULL dereference in unimac_mdio_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Thu, 11 Jan 2018 11:21:51 +0000 (11:21 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 11 Jan 2018 18:56:24 +0000 (13:56 -0500)
platform_get_resource() may fail and return NULL, so we should
better check it's return value to avoid a NULL pointer dereference
a bit later in the code.

This is detected by Coccinelle semantic patch.

@@
expression pdev, res, n, t, e, e1, e2;
@@

res = platform_get_resource(pdev, t, n);
+ if (!res)
+   return -EINVAL;
... when != res == NULL
e = devm_ioremap(e1, res->start, e2);

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/mdio-bcm-unimac.c

index 08e0647b85e2395d5a004b9deeaa9d6a1fcc1b91..8d370667fa1b3e5ada10b299ee35e35294bca798 100644 (file)
@@ -205,6 +205,8 @@ static int unimac_mdio_probe(struct platform_device *pdev)
                return -ENOMEM;
 
        r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+       if (!r)
+               return -EINVAL;
 
        /* Just ioremap, as this MDIO block is usually integrated into an
         * Ethernet MAC controller register range