]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
ASoC: rt5514: Fix rt5514_spi_burst_read() buffer passing
authorGeert Uytterhoeven <geert@linux-m68k.org>
Tue, 30 Jan 2018 13:19:42 +0000 (14:19 +0100)
committerMark Brown <broonie@kernel.org>
Thu, 1 Mar 2018 19:31:49 +0000 (19:31 +0000)
rt5514_dsp_voice_wake_up_put() passes "(u8 *)&buf" to
rt5514_spi_burst_read(), where the cast is needed to silence a compiler
warning:

    sound/soc/codecs/rt5514.c: In function ‘rt5514_dsp_voice_wake_up_put’:
    sound/soc/codecs/rt5514.c:357: warning: passing argument 2 of ‘rt5514_spi_burst_read’ from incompatible pointer type

However, as the variable is declared as an array ("u8 buf[8]"), the
function should just pass "buf" instead.

Fixes: fc9cab05837639ce ("ASoC: rt5514: The DSP clock can be calibrated by the other clock source")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt5514.c

index 2d79571098ac568302164c03c34c1434678ade6c..b358704ee19cb6b7b866d9a306bfdc2f34014982 100644 (file)
@@ -353,8 +353,7 @@ static int rt5514_dsp_voice_wake_up_put(struct snd_kcontrol *kcontrol,
                                msleep(20);
 #if IS_ENABLED(CONFIG_SND_SOC_RT5514_SPI)
                                rt5514_spi_burst_read(RT5514_PLL3_CALIB_CTRL6 |
-                                       RT5514_DSP_MAPPING,
-                                       (u8 *)&buf, sizeof(buf));
+                                       RT5514_DSP_MAPPING, buf, sizeof(buf));
 #else
                                dev_err(component->dev, "There is no SPI driver for"
                                        " loading the firmware\n");