]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
pktgen: Fix memory leak in pktgen_if_write
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Wed, 14 Mar 2018 08:07:27 +0000 (03:07 -0500)
committerDavid S. Miller <davem@davemloft.net>
Wed, 14 Mar 2018 14:02:15 +0000 (10:02 -0400)
_buf_ is an array and the one that must be freed is _tp_ instead.

Fixes: a870a02cc963 ("pktgen: use dynamic allocation for debug print buffer")
Reported-by: Wang Jian <jianjian.wang1@gmail.com>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/pktgen.c

index fd65761e1fed2511c2460a256f4126dbbeb9acd5..545cf08cd558c559b7dec3aad1e84c44de3032d1 100644 (file)
@@ -913,7 +913,7 @@ static ssize_t pktgen_if_write(struct file *file,
                        return PTR_ERR(tp);
 
                pr_debug("%s,%zu  buffer -:%s:-\n", name, count, tp);
-               kfree(buf);
+               kfree(tp);
        }
 
        if (!strcmp(name, "min_pkt_size")) {