]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commitdiff
RISC-V: Support ALIGN relocation type in kernel module
authorZong Li <zong@andestech.com>
Thu, 15 Mar 2018 08:50:47 +0000 (16:50 +0800)
committerPalmer Dabbelt <palmer@sifive.com>
Tue, 3 Apr 2018 03:00:55 +0000 (20:00 -0700)
Just fail on align type. Kernel modules loader didn't do relax
like linker, it is difficult to remove or migrate the code,
but the remnant nop instructions harm the performaace of module.
We expect the building module with the no-relax option.

Signed-off-by: Zong Li <zong@andestech.com>
Signed-off-by: Palmer Dabbelt <palmer@sifive.com>
arch/riscv/kernel/module.c

index 7ab6a9b7238498edaab394339b3df141db67fabe..957933e669b160af72599bd9bbebb4efedf1e4c2 100644 (file)
@@ -240,6 +240,15 @@ static int apply_r_riscv_relax_rela(struct module *me, u32 *location,
        return 0;
 }
 
+static int apply_r_riscv_align_rela(struct module *me, u32 *location,
+                                   Elf_Addr v)
+{
+       pr_err(
+         "%s: The unexpected relocation type 'R_RISCV_ALIGN' from PC = %p\n",
+         me->name, location);
+       return -EINVAL;
+}
+
 static int (*reloc_handlers_rela[]) (struct module *me, u32 *location,
                                Elf_Addr v) = {
        [R_RISCV_64]                    = apply_r_riscv_64_rela,
@@ -257,6 +266,7 @@ static int (*reloc_handlers_rela[]) (struct module *me, u32 *location,
        [R_RISCV_CALL_PLT]              = apply_r_riscv_call_plt_rela,
        [R_RISCV_CALL]                  = apply_r_riscv_call_rela,
        [R_RISCV_RELAX]                 = apply_r_riscv_relax_rela,
+       [R_RISCV_ALIGN]                 = apply_r_riscv_align_rela,
 };
 
 int apply_relocate_add(Elf_Shdr *sechdrs, const char *strtab,