]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
mfd: bd718x7: Remove hardcoded config for button press duration
authorLeonard Crestez <leonard.crestez@nxp.com>
Tue, 21 May 2019 20:41:12 +0000 (20:41 +0000)
committerLee Jones <lee.jones@linaro.org>
Tue, 2 Jul 2019 11:11:31 +0000 (12:11 +0100)
The reset button on imx8mm-evk is tied to PWRON_B pin of bd71847 and the
long press duration is set to zero from OTP. The linux driver overrides
those values and breaks reset from button.

Overwriting OTP or bootloader configuration with some hardcoded defaults
is not desirable, keep already programmed values instead.

Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
Acked-By: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/rohm-bd718x7.c

index 7beb444a57cb7a2ce05a9f16c559d9b9e959e90b..af91092c7fca822362641068baa837f5649123db 100644 (file)
@@ -118,29 +118,6 @@ static int bd718xx_i2c_probe(struct i2c_client *i2c,
                return ret;
        }
 
-       /* Configure short press to 10 milliseconds */
-       ret = regmap_update_bits(bd718xx->chip.regmap,
-                                BD718XX_REG_PWRONCONFIG0,
-                                BD718XX_PWRBTN_PRESS_DURATION_MASK,
-                                BD718XX_PWRBTN_SHORT_PRESS_10MS);
-       if (ret) {
-               dev_err(&i2c->dev,
-                       "Failed to configure button short press timeout\n");
-               return ret;
-       }
-
-       /* Configure long press to 10 seconds */
-       ret = regmap_update_bits(bd718xx->chip.regmap,
-                                BD718XX_REG_PWRONCONFIG1,
-                                BD718XX_PWRBTN_PRESS_DURATION_MASK,
-                                BD718XX_PWRBTN_LONG_PRESS_10S);
-
-       if (ret) {
-               dev_err(&i2c->dev,
-                       "Failed to configure button long press timeout\n");
-               return ret;
-       }
-
        ret = regmap_irq_get_virq(bd718xx->irq_data, BD718XX_INT_PWRBTN_S);
 
        if (ret < 0) {