]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
nvmem: sunxi_sid: fix A64 SID controller support
authorStefan Mavrodiev <stefan@olimex.com>
Sun, 18 Aug 2019 09:33:41 +0000 (10:33 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 18 Aug 2019 10:56:52 +0000 (12:56 +0200)
Like in H3, A64 SID controller doesn't return correct data
when using direct access. It appears that on A64, SID needs
8 bytes of word_size.

Workaround is to enable read by registers.

Signed-off-by: Stefan Mavrodiev <stefan@olimex.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Tested-by: Vasily Khoruzhick <anarsoul@gmail.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20190818093345.29647-4-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/nvmem/sunxi_sid.c

index a079a80ddf2cc75cff1a2fa984b54562b0a52025..e26ef1bbf1981ebcc13aca5fef4af9d4b7aac0a0 100644 (file)
@@ -186,6 +186,7 @@ static const struct sunxi_sid_cfg sun8i_h3_cfg = {
 static const struct sunxi_sid_cfg sun50i_a64_cfg = {
        .value_offset = 0x200,
        .size = 0x100,
+       .need_register_readout = true,
 };
 
 static const struct sunxi_sid_cfg sun50i_h6_cfg = {