]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
staging: vchiq: Move vchiq.h into include directory
authorNicolas Saenz Julienne <nsaenzjulienne@suse.de>
Mon, 29 Jun 2020 15:09:45 +0000 (17:09 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 1 Jul 2020 13:47:08 +0000 (15:47 +0200)
To make the separation clear between vchiq's header files and vchiq.h,
which is to be used by services and is the 'public' API, move it into a
dedicated includes directory.

Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Link: https://lore.kernel.org/r/20200629150945.10720-48-nsaenzjulienne@suse.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/Makefile
drivers/staging/vc04_services/bcm2835-audio/Makefile
drivers/staging/vc04_services/bcm2835-audio/bcm2835.h
drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h [new file with mode: 0644]
drivers/staging/vc04_services/interface/vchiq_arm/vchiq.h [deleted file]
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h
drivers/staging/vc04_services/vchiq-mmal/Makefile
drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c

index e02a9c2abf775ed4244c9cf5968e9082312ee941..7546d70116a04a2ba517f085986a132c10e19239 100644 (file)
@@ -12,5 +12,5 @@ obj-$(CONFIG_SND_BCM2835)             += bcm2835-audio/
 obj-$(CONFIG_VIDEO_BCM2835)            += bcm2835-camera/
 obj-$(CONFIG_BCM2835_VCHIQ_MMAL)       += vchiq-mmal/
 
-ccflags-y += -D__VCCOREVER__=0x04000000
+ccflags-y += -I $(srctree)/$(src)/include  -D__VCCOREVER__=0x04000000
 
index 13fa6d7d9745b1de80d4f14245ae70d203353cc7..d59fe4dde615365af00b56e48d96c7888bd018cb 100644 (file)
@@ -2,4 +2,4 @@
 obj-$(CONFIG_SND_BCM2835)      += snd-bcm2835.o
 snd-bcm2835-objs               := bcm2835.o bcm2835-ctl.o bcm2835-pcm.o bcm2835-vchiq.o
 
-ccflags-y += -I $(srctree)/$(src)/.. -D__VCCOREVER__=0x04000000
+ccflags-y += -I $(srctree)/$(src)/../include -D__VCCOREVER__=0x04000000
index ca220f5230eca29f8036bd71fb66962b6998936e..1b36475872d6c0e35a309f17a5e3730e63a67248 100644 (file)
@@ -6,10 +6,10 @@
 
 #include <linux/device.h>
 #include <linux/wait.h>
+#include <linux/raspberrypi/vchiq.h>
 #include <sound/core.h>
 #include <sound/pcm.h>
 #include <sound/pcm-indirect.h>
-#include "interface/vchiq_arm/vchiq.h"
 
 #define MAX_SUBSTREAMS   (8)
 #define AVAIL_SUBSTREAMS_MASK  (0xff)
diff --git a/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h b/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h
new file mode 100644 (file)
index 0000000..cb9ef9a
--- /dev/null
@@ -0,0 +1,103 @@
+/* SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause */
+/* Copyright (c) 2010-2012 Broadcom. All rights reserved. */
+
+#ifndef VCHIQ_H
+#define VCHIQ_H
+
+#define VCHIQ_MAKE_FOURCC(x0, x1, x2, x3) \
+                       (((x0) << 24) | ((x1) << 16) | ((x2) << 8) | (x3))
+
+enum vchiq_reason {
+       VCHIQ_SERVICE_OPENED,         /* service, -, -             */
+       VCHIQ_SERVICE_CLOSED,         /* service, -, -             */
+       VCHIQ_MESSAGE_AVAILABLE,      /* service, header, -        */
+       VCHIQ_BULK_TRANSMIT_DONE,     /* service, -, bulk_userdata */
+       VCHIQ_BULK_RECEIVE_DONE,      /* service, -, bulk_userdata */
+       VCHIQ_BULK_TRANSMIT_ABORTED,  /* service, -, bulk_userdata */
+       VCHIQ_BULK_RECEIVE_ABORTED    /* service, -, bulk_userdata */
+};
+
+enum vchiq_status {
+       VCHIQ_ERROR   = -1,
+       VCHIQ_SUCCESS = 0,
+       VCHIQ_RETRY   = 1
+};
+
+enum vchiq_bulk_mode {
+       VCHIQ_BULK_MODE_CALLBACK,
+       VCHIQ_BULK_MODE_BLOCKING,
+       VCHIQ_BULK_MODE_NOCALLBACK,
+       VCHIQ_BULK_MODE_WAITING         /* Reserved for internal use */
+};
+
+enum vchiq_service_option {
+       VCHIQ_SERVICE_OPTION_AUTOCLOSE,
+       VCHIQ_SERVICE_OPTION_SLOT_QUOTA,
+       VCHIQ_SERVICE_OPTION_MESSAGE_QUOTA,
+       VCHIQ_SERVICE_OPTION_SYNCHRONOUS,
+       VCHIQ_SERVICE_OPTION_TRACE
+};
+
+struct vchiq_header {
+       /* The message identifier - opaque to applications. */
+       int msgid;
+
+       /* Size of message data. */
+       unsigned int size;
+
+       char data[0];           /* message */
+};
+
+struct vchiq_element {
+       const void __user *data;
+       unsigned int size;
+};
+
+struct vchiq_service_base {
+       int fourcc;
+       enum vchiq_status (*callback)(enum vchiq_reason reason,
+                                     struct vchiq_header *header,
+                                     unsigned int handle,
+                                     void *bulk_userdata);
+       void *userdata;
+};
+
+struct vchiq_service_params {
+       int fourcc;
+       enum vchiq_status (*callback)(enum vchiq_reason reason,
+                                     struct vchiq_header *header,
+                                     unsigned int handle,
+                                     void *bulk_userdata);
+       void *userdata;
+       short version;       /* Increment for non-trivial changes */
+       short version_min;   /* Update for incompatible changes */
+};
+
+struct vchiq_instance;
+
+extern enum vchiq_status vchiq_initialise(struct vchiq_instance **pinstance);
+extern enum vchiq_status vchiq_shutdown(struct vchiq_instance *instance);
+extern enum vchiq_status vchiq_connect(struct vchiq_instance *instance);
+extern enum vchiq_status vchiq_open_service(struct vchiq_instance *instance,
+       const struct vchiq_service_params *params,
+       unsigned int *pservice);
+extern enum vchiq_status vchiq_close_service(unsigned int service);
+extern enum vchiq_status vchiq_use_service(unsigned int service);
+extern enum vchiq_status vchiq_release_service(unsigned int service);
+extern void vchiq_msg_queue_push(unsigned handle, struct vchiq_header *header);
+extern void           vchiq_release_message(unsigned int service,
+       struct vchiq_header *header);
+extern int vchiq_queue_kernel_message(unsigned handle, void *data,
+                                     unsigned size);
+extern enum vchiq_status vchiq_bulk_transmit(unsigned int service,
+       const void *data, unsigned int size, void *userdata,
+       enum vchiq_bulk_mode mode);
+extern enum vchiq_status vchiq_bulk_receive(unsigned int service,
+       void *data, unsigned int size, void *userdata,
+       enum vchiq_bulk_mode mode);
+extern void *vchiq_get_service_userdata(unsigned int service);
+extern enum vchiq_status vchiq_get_peer_version(unsigned int handle,
+      short *peer_version);
+extern struct vchiq_header *vchiq_msg_hold(unsigned handle);
+
+#endif /* VCHIQ_H */
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq.h
deleted file mode 100644 (file)
index cb9ef9a..0000000
+++ /dev/null
@@ -1,103 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause */
-/* Copyright (c) 2010-2012 Broadcom. All rights reserved. */
-
-#ifndef VCHIQ_H
-#define VCHIQ_H
-
-#define VCHIQ_MAKE_FOURCC(x0, x1, x2, x3) \
-                       (((x0) << 24) | ((x1) << 16) | ((x2) << 8) | (x3))
-
-enum vchiq_reason {
-       VCHIQ_SERVICE_OPENED,         /* service, -, -             */
-       VCHIQ_SERVICE_CLOSED,         /* service, -, -             */
-       VCHIQ_MESSAGE_AVAILABLE,      /* service, header, -        */
-       VCHIQ_BULK_TRANSMIT_DONE,     /* service, -, bulk_userdata */
-       VCHIQ_BULK_RECEIVE_DONE,      /* service, -, bulk_userdata */
-       VCHIQ_BULK_TRANSMIT_ABORTED,  /* service, -, bulk_userdata */
-       VCHIQ_BULK_RECEIVE_ABORTED    /* service, -, bulk_userdata */
-};
-
-enum vchiq_status {
-       VCHIQ_ERROR   = -1,
-       VCHIQ_SUCCESS = 0,
-       VCHIQ_RETRY   = 1
-};
-
-enum vchiq_bulk_mode {
-       VCHIQ_BULK_MODE_CALLBACK,
-       VCHIQ_BULK_MODE_BLOCKING,
-       VCHIQ_BULK_MODE_NOCALLBACK,
-       VCHIQ_BULK_MODE_WAITING         /* Reserved for internal use */
-};
-
-enum vchiq_service_option {
-       VCHIQ_SERVICE_OPTION_AUTOCLOSE,
-       VCHIQ_SERVICE_OPTION_SLOT_QUOTA,
-       VCHIQ_SERVICE_OPTION_MESSAGE_QUOTA,
-       VCHIQ_SERVICE_OPTION_SYNCHRONOUS,
-       VCHIQ_SERVICE_OPTION_TRACE
-};
-
-struct vchiq_header {
-       /* The message identifier - opaque to applications. */
-       int msgid;
-
-       /* Size of message data. */
-       unsigned int size;
-
-       char data[0];           /* message */
-};
-
-struct vchiq_element {
-       const void __user *data;
-       unsigned int size;
-};
-
-struct vchiq_service_base {
-       int fourcc;
-       enum vchiq_status (*callback)(enum vchiq_reason reason,
-                                     struct vchiq_header *header,
-                                     unsigned int handle,
-                                     void *bulk_userdata);
-       void *userdata;
-};
-
-struct vchiq_service_params {
-       int fourcc;
-       enum vchiq_status (*callback)(enum vchiq_reason reason,
-                                     struct vchiq_header *header,
-                                     unsigned int handle,
-                                     void *bulk_userdata);
-       void *userdata;
-       short version;       /* Increment for non-trivial changes */
-       short version_min;   /* Update for incompatible changes */
-};
-
-struct vchiq_instance;
-
-extern enum vchiq_status vchiq_initialise(struct vchiq_instance **pinstance);
-extern enum vchiq_status vchiq_shutdown(struct vchiq_instance *instance);
-extern enum vchiq_status vchiq_connect(struct vchiq_instance *instance);
-extern enum vchiq_status vchiq_open_service(struct vchiq_instance *instance,
-       const struct vchiq_service_params *params,
-       unsigned int *pservice);
-extern enum vchiq_status vchiq_close_service(unsigned int service);
-extern enum vchiq_status vchiq_use_service(unsigned int service);
-extern enum vchiq_status vchiq_release_service(unsigned int service);
-extern void vchiq_msg_queue_push(unsigned handle, struct vchiq_header *header);
-extern void           vchiq_release_message(unsigned int service,
-       struct vchiq_header *header);
-extern int vchiq_queue_kernel_message(unsigned handle, void *data,
-                                     unsigned size);
-extern enum vchiq_status vchiq_bulk_transmit(unsigned int service,
-       const void *data, unsigned int size, void *userdata,
-       enum vchiq_bulk_mode mode);
-extern enum vchiq_status vchiq_bulk_receive(unsigned int service,
-       void *data, unsigned int size, void *userdata,
-       enum vchiq_bulk_mode mode);
-extern void *vchiq_get_service_userdata(unsigned int service);
-extern enum vchiq_status vchiq_get_peer_version(unsigned int handle,
-      short *peer_version);
-extern struct vchiq_header *vchiq_msg_hold(unsigned handle);
-
-#endif /* VCHIQ_H */
index 8a27f3d7217ee5cd3eff8c66cae34f6ad94c9991..e67692879249cac0dd7f00f6da2547629a1a31e3 100644 (file)
 #include <linux/kref.h>
 #include <linux/rcupdate.h>
 #include <linux/wait.h>
+#include <linux/raspberrypi/vchiq.h>
 
 #include "vchiq_cfg.h"
 
-#include "vchiq.h"
 
 /* Do this so that we can test-build the code on non-rpi systems */
 #if IS_ENABLED(CONFIG_RASPBERRYPI_FIRMWARE)
index f285d754ad28df6551d02a3cec8a698d12c3c157..3653fd99d8a18447265e3dbe26d731292c4f1d5b 100644 (file)
@@ -5,7 +5,7 @@
 #define VCHIQ_IOCTLS_H
 
 #include <linux/ioctl.h>
-#include "vchiq.h"
+#include <linux/raspberrypi/vchiq.h>
 
 #define VCHIQ_IOC_MAGIC 0xc4
 #define VCHIQ_INVALID_HANDLE (~0)
index f8164c33aec3dc966b12dbffbbbc401f4c708b10..b2a830f48acc63b9575791055b5b172cb4517f74 100644 (file)
@@ -5,4 +5,5 @@ obj-$(CONFIG_BCM2835_VCHIQ_MMAL) += bcm2835-mmal-vchiq.o
 
 ccflags-y += \
        -I$(srctree)/$(src)/.. \
+       -I$(srctree)/$(src)/../include \
        -D__VCCOREVER__=0x04000000
index 7da9a4c1ac03db4bbe0af9f9f79939a00913ee6c..a075cd63da7fd52e5e6ca9cfef8fb8579bbc4fe0 100644 (file)
 #include <linux/slab.h>
 #include <linux/completion.h>
 #include <linux/vmalloc.h>
+#include <linux/raspberrypi/vchiq.h>
 #include <media/videobuf2-vmalloc.h>
 
 #include "mmal-common.h"
 #include "mmal-vchiq.h"
 #include "mmal-msg.h"
 
-#include "interface/vchiq_arm/vchiq.h"
-
 /*
  * maximum number of components supported.
  * This matches the maximum permitted by default on the VPU