]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
wifi: ath10k: Fix return value in ath10k_pci_init()
authorXiu Jianfeng <xiujianfeng@huawei.com>
Thu, 10 Nov 2022 06:19:26 +0000 (14:19 +0800)
committerKalle Valo <quic_kvalo@quicinc.com>
Thu, 17 Nov 2022 12:56:59 +0000 (14:56 +0200)
This driver is attempting to register to support two different buses.
if either of these is successful then ath10k_pci_init() should return 0
so that hardware attached to the successful bus can be probed and
supported. only if both of these are unsuccessful should ath10k_pci_init()
return an errno.

Fixes: 0b523ced9a3c ("ath10k: add basic skeleton to support ahb")
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
Reviewed-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20221110061926.18163-1-xiujianfeng@huawei.com
drivers/net/wireless/ath/ath10k/pci.c

index e56c6a6b137914bf4ea535087524f7a531a46204..728d607289c36674fbada525d01fefea4b987514 100644 (file)
@@ -3792,18 +3792,22 @@ static struct pci_driver ath10k_pci_driver = {
 
 static int __init ath10k_pci_init(void)
 {
-       int ret;
+       int ret1, ret2;
 
-       ret = pci_register_driver(&ath10k_pci_driver);
-       if (ret)
+       ret1 = pci_register_driver(&ath10k_pci_driver);
+       if (ret1)
                printk(KERN_ERR "failed to register ath10k pci driver: %d\n",
-                      ret);
+                      ret1);
 
-       ret = ath10k_ahb_init();
-       if (ret)
-               printk(KERN_ERR "ahb init failed: %d\n", ret);
+       ret2 = ath10k_ahb_init();
+       if (ret2)
+               printk(KERN_ERR "ahb init failed: %d\n", ret2);
 
-       return ret;
+       if (ret1 && ret2)
+               return ret1;
+
+       /* registered to at least one bus */
+       return 0;
 }
 module_init(ath10k_pci_init);