]> git.proxmox.com Git - mirror_qemu.git/commitdiff
nbd: Fix nbd_establish_connection()'s return value
authorMax Reitz <mreitz@redhat.com>
Wed, 25 Feb 2015 18:08:16 +0000 (13:08 -0500)
committerPaolo Bonzini <pbonzini@redhat.com>
Wed, 18 Mar 2015 11:05:38 +0000 (12:05 +0100)
unix_connect_opts() and inet_connect_opts() do not necessarily set errno
(if at all); therefore, nbd_establish_connection() should not literally
return -errno on error.

Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-Id: <1424887718-10800-4-git-send-email-mreitz@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
block/nbd.c

index 6634a696646618ca6dda10c0081dde0d996cae79..217618612d457c8fa8e041e5844d861c7f490fe3 100644 (file)
@@ -248,7 +248,7 @@ static int nbd_establish_connection(BlockDriverState *bs, Error **errp)
     /* Failed to establish connection */
     if (sock < 0) {
         logout("Failed to establish connection to NBD server\n");
-        return -errno;
+        return -EIO;
     }
 
     return sock;