ipv6: Mark dead nexthops with appropriate flags

When a netdev is put administratively down or unregistered all the
nexthops using it as their nexthop device should be marked with the
'dead' and 'linkdown' flags.

Currently, when a route is dumped its nexthop device is tested and the
flags are set accordingly. A similar check is performed during route
lookup.

Instead, we can simply mark the nexthops based on netdev events and
avoid checking the netdev's state during route dump and lookup.

Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Acked-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index c557362daa23ef4411fe14b7cc64ecdb6775f63d..f5eda0aeab55f119ad09bdfbb6a677ceb90fce95 100644 (file)
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -3473,8 +3473,10 @@ static int fib6_ifdown(struct rt6_info *rt, void *arg)
        if (rt->dst.dev == dev &&
            rt != adn->net->ipv6.ip6_null_entry &&
            (rt->rt6i_nsiblings == 0 || netdev_unregistering(dev) ||
-            !rt->rt6i_idev->cnf.ignore_routes_with_linkdown))
+            !rt->rt6i_idev->cnf.ignore_routes_with_linkdown)) {
+               rt->rt6i_nh_flags |= (RTNH_F_DEAD | RTNH_F_LINKDOWN);
                return -1;
+       }
 
        return 0;
 }