]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commitdiff
x86/entry/64: Shorten TEST instructions
authorBorislav Petkov <bp@suse.de>
Thu, 2 Nov 2017 12:09:26 +0000 (13:09 +0100)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Sat, 6 Jan 2018 12:22:57 +0000 (13:22 +0100)
CVE-2017-5754

Convert TESTL to TESTB and save 3 bytes per callsite.

No functionality change.

Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Dave Hansen <dave.hansen@intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20171102120926.4srwerqrr7g72e2k@pd.tnic
Signed-off-by: Ingo Molnar <mingo@kernel.org>
(cherry picked from commit 1e4c4f610f774df6088d7c065b2dd4d22adba698)
Signed-off-by: Andy Whitcroft <apw@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
arch/x86/entry/entry_64.S

index 05501c781c207ec22656f2cb5a3d0d6b4922ea80..2491b3b25b9adef910bde46df5db032d59b56541 100644 (file)
@@ -620,7 +620,7 @@ GLOBAL(retint_user)
 GLOBAL(swapgs_restore_regs_and_return_to_usermode)
 #ifdef CONFIG_DEBUG_ENTRY
        /* Assert that pt_regs indicates user mode. */
-       testl   $3, CS(%rsp)
+       testb   $3, CS(%rsp)
        jnz     1f
        ud2
 1:
@@ -653,7 +653,7 @@ retint_kernel:
 GLOBAL(restore_regs_and_return_to_kernel)
 #ifdef CONFIG_DEBUG_ENTRY
        /* Assert that pt_regs indicates kernel mode. */
-       testl   $3, CS(%rsp)
+       testb   $3, CS(%rsp)
        jz      1f
        ud2
 1: