]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
gigaset: asyncdata: mark expected switch fall-throughs
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Fri, 5 Oct 2018 13:29:09 +0000 (15:29 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 5 Oct 2018 17:47:49 +0000 (10:47 -0700)
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Notice that in this particular case, I replaced the
" --v-- fall through --v-- " comment with a proper
"fall through", which is what GCC is expecting to find.

Addresses-Coverity-ID: 1364476 ("Missing break in switch")
Addresses-Coverity-ID: 1364477 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/isdn/gigaset/asyncdata.c

index bc208557f7839853b85776a9a6b8acb6d556d41c..c0cbee06bc21164660d93fb32c4110e5866d5735 100644 (file)
@@ -65,7 +65,7 @@ static unsigned cmd_loop(unsigned numbytes, struct inbuf_t *inbuf)
                                cs->respdata[0] = 0;
                                break;
                        }
-                       /* --v-- fall through --v-- */
+                       /* fall through */
                case '\r':
                        /* end of message line, pass to response handler */
                        if (cbytes >= MAX_RESP_SIZE) {
@@ -100,7 +100,7 @@ static unsigned cmd_loop(unsigned numbytes, struct inbuf_t *inbuf)
                                goto exit;
                        }
                        /* quoted or not in DLE mode: treat as regular data */
-                       /* --v-- fall through --v-- */
+                       /* fall through */
                default:
                        /* append to line buffer if possible */
                        if (cbytes < MAX_RESP_SIZE)