]> git.proxmox.com Git - mirror_frr.git/commitdiff
bgpd: Make sure we have peer->notify.data before returning for SNMP
authorDonatas Abraitis <donatas@opensourcerouting.org>
Thu, 15 Dec 2022 13:14:40 +0000 (15:14 +0200)
committerDonatas Abraitis <donatas@opensourcerouting.org>
Mon, 19 Dec 2022 21:27:33 +0000 (23:27 +0200)
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
bgpd/bgp_snmp_bgp4v2.c

index 2d70aa94d35b0c7ea1f4b02db03f0c296abf856b..20854ff64e536158399da7059dbe75a589ad0a7d 100644 (file)
@@ -367,9 +367,10 @@ static uint8_t *bgpv2PeerErrorsTable(struct variable *v, oid name[],
                }
                return SNMP_STRING("");
        case BGP4V2_PEER_LAST_ERROR_SENT_DATA:
-               if (peer->last_reset == PEER_DOWN_NOTIFY_SEND ||
-                   peer->last_reset == PEER_DOWN_RTT_SHUTDOWN ||
-                   peer->last_reset == PEER_DOWN_USER_SHUTDOWN)
+               if ((peer->last_reset == PEER_DOWN_NOTIFY_SEND ||
+                    peer->last_reset == PEER_DOWN_RTT_SHUTDOWN ||
+                    peer->last_reset == PEER_DOWN_USER_SHUTDOWN) &&
+                   peer->notify.data)
                        return SNMP_STRING(peer->notify.data);
                else
                        return SNMP_STRING("");