]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
ARM: dts: imx: Fix the SPI chipselect polarity
authorFabio Estevam <festevam@gmail.com>
Wed, 19 Aug 2020 21:04:24 +0000 (18:04 -0300)
committerShawn Guo <shawnguo@kernel.org>
Sun, 30 Aug 2020 01:37:20 +0000 (09:37 +0800)
The conversion of the spi-imx driver to use GPIO descriptors
in commit 8cdcd8aeee28 ("spi: imx/fsl-lpspi: Convert to GPIO descriptors")
helped to detect the following SPI chipselect polarity mismatch on an
imx6q-sabresd:

[    4.854337] m25p80@0 enforce active low on chipselect handle

Prior to the above commit, the chipselect polarity passed via cs-gpios
property was ignored and considered active-low.

The reason for such mismatch is clearly explained in the comments inside
drivers/gpio/gpiolib-of.c:

 * SPI children have active low chip selects
 * by default. This can be specified negatively
 * by just omitting "spi-cs-high" in the
 * device node, or actively by tagging on
 * GPIO_ACTIVE_LOW as flag in the device
 * tree. If the line is simultaneously
 * tagged as active low in the device tree
 * and has the "spi-cs-high" set, we get a
 * conflict and the "spi-cs-high" flag will
 * take precedence.

To properly represent the SPI chipselect polarity, change it to active-low
when the "spi-cs-high" property is absent.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
56 files changed:
arch/arm/boot/dts/imx27-phytec-phycard-s-som.dtsi
arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts
arch/arm/boot/dts/imx50-evk.dts
arch/arm/boot/dts/imx51-apf51dev.dts
arch/arm/boot/dts/imx53-m53menlo.dts
arch/arm/boot/dts/imx53-smd.dts
arch/arm/boot/dts/imx53-tqma53.dtsi
arch/arm/boot/dts/imx53-voipac-dmm-668.dtsi
arch/arm/boot/dts/imx6dl-aristainetos_4.dts
arch/arm/boot/dts/imx6dl-eckelmann-ci4x10.dts
arch/arm/boot/dts/imx6dl-prtrvt.dts
arch/arm/boot/dts/imx6dl-prtvt7.dts
arch/arm/boot/dts/imx6q-ba16.dtsi
arch/arm/boot/dts/imx6q-bx50v3.dtsi
arch/arm/boot/dts/imx6q-cm-fx6.dts
arch/arm/boot/dts/imx6q-dhcom-som.dtsi
arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts
arch/arm/boot/dts/imx6q-dms-ba16.dts
arch/arm/boot/dts/imx6q-gw5400-a.dts
arch/arm/boot/dts/imx6q-kontron-samx6i.dtsi
arch/arm/boot/dts/imx6q-prti6q.dts
arch/arm/boot/dts/imx6q-var-dt6customboard.dts
arch/arm/boot/dts/imx6qdl-apalis.dtsi
arch/arm/boot/dts/imx6qdl-aristainetos.dtsi
arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi
arch/arm/boot/dts/imx6qdl-colibri.dtsi
arch/arm/boot/dts/imx6qdl-dfi-fs700-m60.dtsi
arch/arm/boot/dts/imx6qdl-emcon.dtsi
arch/arm/boot/dts/imx6qdl-gw52xx.dtsi
arch/arm/boot/dts/imx6qdl-gw54xx.dtsi
arch/arm/boot/dts/imx6qdl-gw560x.dtsi
arch/arm/boot/dts/imx6qdl-gw5910.dtsi
arch/arm/boot/dts/imx6qdl-gw5912.dtsi
arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
arch/arm/boot/dts/imx6qdl-kontron-samx6i.dtsi
arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi
arch/arm/boot/dts/imx6qdl-nitrogen6_som2.dtsi
arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi
arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
arch/arm/boot/dts/imx6qdl-pico.dtsi
arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
arch/arm/boot/dts/imx6qdl-sabrelite.dtsi
arch/arm/boot/dts/imx6qdl-sabresd.dtsi
arch/arm/boot/dts/imx6qdl-ts4900.dtsi
arch/arm/boot/dts/imx6qdl-ts7970.dtsi
arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
arch/arm/boot/dts/imx6sl-evk.dts
arch/arm/boot/dts/imx6sx-softing-vining-2000.dts
arch/arm/boot/dts/imx6ul-kontron-n6x1x-s.dtsi
arch/arm/boot/dts/imx6ul-kontron-n6x1x-som-common.dtsi
arch/arm/boot/dts/imx6ul-phytec-segin.dtsi
arch/arm/boot/dts/imx6ull-colibri.dtsi
arch/arm/boot/dts/imx7-colibri.dtsi
arch/arm/boot/dts/imx7d-sdb.dts
arch/arm/boot/dts/imx7d-zii-rmu2.dts
arch/arm/boot/dts/imx7d-zii-rpu2.dts

index 52c95248e25d2010b21ecefb5b7f91a4d0447a8d..303f920201c505d29b6397eef95e51cd55296078 100644 (file)
@@ -18,8 +18,8 @@
 };
 
 &cspi1 {
-       cs-gpios = <&gpio4 28 GPIO_ACTIVE_HIGH>,
-                  <&gpio4 27 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio4 28 GPIO_ACTIVE_LOW>,
+                  <&gpio4 27 GPIO_ACTIVE_LOW>;
        status = "okay";
 };
 
index bf883e45576a64dfe7ac5755534dce246443b436..344e77790152416ffe6a4f30753487d0c1d62752 100644 (file)
@@ -65,7 +65,7 @@
 
 &cspi1 {
        pinctrl-0 = <&pinctrl_cspi1>, <&pinctrl_cspi1cs1>;
-       cs-gpios = <&gpio4 28 GPIO_ACTIVE_HIGH>,
+       cs-gpios = <&gpio4 28 GPIO_ACTIVE_LOW>,
                   <&gpio4 27 GPIO_ACTIVE_LOW>;
 };
 
index a25da415cb02ec8a1595bdbf3138f3e5de05d740..878e89c201904f022ee19498bc74c03370703476 100644 (file)
@@ -20,7 +20,7 @@
 &cspi {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_cspi>;
-       cs-gpios = <&gpio4 11 0>, <&gpio4 13 0>;
+       cs-gpios = <&gpio4 11 GPIO_ACTIVE_LOW>, <&gpio4 13 GPIO_ACTIVE_LOW>;
        status = "okay";
 
        flash: m25p32@1 {
index 563c1aae8c0c2a6808079afe90cbd107772d1c61..c66f274ba4e94791eaff726e3ccc7c580c383342 100644 (file)
@@ -74,8 +74,8 @@
 &ecspi1 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
-       cs-gpios = <&gpio4 24 GPIO_ACTIVE_HIGH>,
-                  <&gpio4 25 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio4 24 GPIO_ACTIVE_LOW>,
+                  <&gpio4 25 GPIO_ACTIVE_LOW>;
        status = "okay";
 };
 
index 719ed5ca454affaba60ceb19fc662bf236515d76..f98691ae4415bd1033bc0e9103a09802fef4091e 100644 (file)
 &ecspi2 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi2>;
-       cs-gpios = <&gpio2 26 GPIO_ACTIVE_HIGH>, <&gpio2 27 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio2 26 GPIO_ACTIVE_LOW>, <&gpio2 27 GPIO_ACTIVE_LOW>;
        status = "okay";
 
        spidev@0 {
index ec9fb8940ffa22e7c587bba9b7d4fe498988c47c..9be44e80718865ee72cdf1ff9f1be49db2f333c4 100644 (file)
@@ -58,7 +58,7 @@
 &ecspi1 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
-       cs-gpios = <&gpio2 30 0>, <&gpio3 19 0>;
+       cs-gpios = <&gpio2 30 GPIO_ACTIVE_LOW>, <&gpio3 19 GPIO_ACTIVE_LOW>;
        status = "okay";
 
        zigbee: mc1323@0 {
index 9a6cb138adf313f1a705018b58507470e979771d..7e7f9f3b3906e2ae3164cd30b6735f662288e530 100644 (file)
@@ -50,8 +50,8 @@
 &ecspi1 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
-       cs-gpios = <&gpio2 30 0>, <&gpio3 19 0>,
-                  <&gpio3 24 0>, <&gpio3 25 0>;
+       cs-gpios = <&gpio2 30 GPIO_ACTIVE_LOW>, <&gpio3 19 GPIO_ACTIVE_LOW>,
+                  <&gpio3 24 GPIO_ACTIVE_LOW>, <&gpio3 25 GPIO_ACTIVE_LOW>;
        status = "disabled";
 };
 
 &cspi {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_cspi>;
-       cs-gpios = <&gpio1 18 0>, <&gpio1 19 0>,
-                  <&gpio1 21 0>;
+       cs-gpios = <&gpio1 18 GPIO_ACTIVE_LOW>, <&gpio1 19 GPIO_ACTIVE_LOW>,
+                  <&gpio1 21 GPIO_ACTIVE_LOW>;
        status = "disabled";
 };
 
index 289feab42b88c6356d607bd83dd162fa07ec2e91..24859d0c09c1cc2d6095e4339b38641444d16c1a 100644 (file)
 &ecspi1 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
-       cs-gpios = <&gpio2 30 0>, <&gpio3 19 0>, <&gpio2 16 0>, <&gpio2 17 0>;
+       cs-gpios = <&gpio2 30 GPIO_ACTIVE_LOW>, <&gpio3 19 GPIO_ACTIVE_LOW>,
+                  <&gpio2 16 GPIO_ACTIVE_LOW>, <&gpio2 17 GPIO_ACTIVE_LOW>;
        status = "okay";
 };
 
index 809ca56110724e4810f92dc86113a44b95dafafc..5c7e8530069596dd84f640e9daea023b3a8c0932 100644 (file)
@@ -61,7 +61,7 @@
 };
 
 &ecspi2 {
-       cs-gpios = <&gpio3 24 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio3 24 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi2>;
        status = "okay";
index 9eb2b73951b2a63102b14c6a805bed7f9f58d9c2..b4a9523e325b4e0ce9781cf36756c8542ed97573 100644 (file)
@@ -67,7 +67,7 @@
 &ecspi2 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi2>;
-       cs-gpios = <&gpio5 12 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio5 12 GPIO_ACTIVE_LOW>;
        status = "okay";
 
        flash@0 {
@@ -80,7 +80,7 @@
 &ecspi1 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
-       cs-gpios = <&gpio5 25 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio5 25 GPIO_ACTIVE_LOW>;
        status = "okay";
 
        tpm@0 {
index fa882458957b9d7170593d2d2e2c1e4cb660c2f1..5ac84445e9cc1893edd2e3525b335a5be930bde9 100644 (file)
@@ -37,7 +37,7 @@
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio3 19 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
        status = "okay";
@@ -52,7 +52,7 @@
 };
 
 &ecspi3 {
-       cs-gpios = <&gpio4 24 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio4 24 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi3>;
        status = "okay";
index 306b4f7bf76247f03a2b7fea09c98cbba955b4ae..ae6da241f13e5c529d8b0dc56ffd05805df8c209 100644 (file)
 };
 
 &ecspi2 {
-       cs-gpios = <&gpio2 26 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio2 26 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi2>;
        status = "okay";
index fc81f2f4b62d80cdfb7ae0c6341e8fb7ebe59713..e4578ed3371ef27dcf2b9f0cecadb024b6aae92e 100644 (file)
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio2 30 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio2 30 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
        status = "okay";
index 1fb67cd2b2a10fc47fac677ac22118a38a208301..02812e6cb302e29c9c5019ea86885e2ce1609a6c 100644 (file)
 };
 
 &ecspi5 {
-       cs-gpios = <&gpio1 17 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio1 17 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi5>;
        status = "okay";
index cab9e92531c7f54636e174431aaaa6e2b087ad7e..bfb530f29d9deaaf1ee156ac5e6afd907b8e64d6 100644 (file)
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio2 30 GPIO_ACTIVE_HIGH>, <&gpio3 19 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio2 30 GPIO_ACTIVE_LOW>, <&gpio3 19 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
        status = "okay";
index 87f0aa897086e100d9ea368f5fec9dfb269cec62..236fc205c38903cd1b3f4ba7e2fffb13972c18fb 100644 (file)
@@ -59,7 +59,7 @@
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio2 30 GPIO_ACTIVE_HIGH>, <&gpio4 11 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio2 30 GPIO_ACTIVE_LOW>, <&gpio4 11 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
        status = "okay";
index f9df207b2778be19c861e846d6bf7805310a9e50..fa2307d8ce8610aad082e38a8d5ad6b30666c45b 100644 (file)
@@ -99,7 +99,7 @@
 &ecspi5 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi5>;
-       cs-gpios = <&gpio1 12 0>;
+       cs-gpios = <&gpio1 12 GPIO_ACTIVE_LOW>;
        status = "okay";
 
        flash: m25p80@0 {
index 57761f3172fa78f3e0f28e71fb45fe47e66f0a83..48fb47e715f6dfaa93b4702b301842539c39a988 100644 (file)
@@ -42,7 +42,7 @@
 };
 
 &ecspi5 {
-       cs-gpios = <&gpio1 17 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio1 17 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi5>;
        status = "okay";
index b6e2b580051d97d830b750dec247e791df03ab33..4cde45d5c90c80f52f32c13612892e205f043a71 100644 (file)
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio3 19 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
        status = "okay";
index 2618eccfe50dfe07333ad105296f2b1bf0c1ecb6..1a6dcf77fb13a53d7fd9bcc45687987fde774b3e 100644 (file)
@@ -15,9 +15,9 @@
 /* Quad/Dual SoMs have 3 chip-select signals */
 &ecspi4 {
        fsl,spi-num-chipselects = <3>;
-       cs-gpios = <&gpio3 24 GPIO_ACTIVE_HIGH>,
-                  <&gpio3 29 GPIO_ACTIVE_HIGH>,
-                  <&gpio3 25 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio3 24 GPIO_ACTIVE_LOW>,
+                  <&gpio3 29 GPIO_ACTIVE_LOW>,
+                  <&gpio3 25 GPIO_ACTIVE_LOW>;
 };
 
 &pinctrl_ecspi4 {
index de6cbaab8b4997225462117670ac62260e60dd73..d112b50f8c5d98a47f9330335dabe26637af6be8 100644 (file)
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio3 19 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
        status = "okay";
 };
 
 &ecspi2 {
-       cs-gpios = <&gpio2 26 GPIO_ACTIVE_HIGH>, <&gpio4 25 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio2 26 GPIO_ACTIVE_LOW>, <&gpio4 25 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi2 &pinctrl_ecspi2_cs>;
        status = "okay";
 };
 
 &ecspi3 {
-       cs-gpios = <&gpio4 24 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio4 24 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi3>;
        status = "okay";
index a57c2e3a843597cfef697b8f7a51c128c8c124ac..63550351340da51e3ccfe17e1619e09918accca0 100644 (file)
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio4 9 GPIO_ACTIVE_HIGH>,
-                  <&gpio4 10 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio4 9 GPIO_ACTIVE_LOW>,
+                  <&gpio4 10 GPIO_ACTIVE_LOW>;
        status = "okay";
 };
 
index dbdd7db603258433a56eb1fb1c627062c0786d6b..30fa349f9d0547fc410e8730549b48546cccf668 100644 (file)
 
 /* Apalis SPI1 */
 &ecspi1 {
-       cs-gpios = <&gpio5 25 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio5 25 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
        status = "disabled";
 
 /* Apalis SPI2 */
 &ecspi2 {
-       cs-gpios = <&gpio2 26 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio2 26 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi2>;
        status = "disabled";
index d954661fa0552c9d567e91f517663a6182d40707..e21f6ac864e5492ad396074aed7dd916112ed6d3 100644 (file)
@@ -91,7 +91,7 @@
 };
 
 &ecspi4 {
-       cs-gpios = <&gpio3 20 0>;
+       cs-gpios = <&gpio3 20 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi4>;
        status = "okay";
index d38630d4b892f1e855c2bc0c6e9488de4e667f0b..ead7ba27e10532fdfe2c74c465a3394f9fd298a0 100644 (file)
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio4 9 GPIO_ACTIVE_HIGH
-                   &gpio4 10 GPIO_ACTIVE_HIGH
-                   &gpio4 11 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio4 9 GPIO_ACTIVE_LOW
+                   &gpio4 10 GPIO_ACTIVE_LOW
+                   &gpio4 11 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
        status = "okay";
 };
 
 &ecspi2 {
-       cs-gpios = <&gpio2 26 GPIO_ACTIVE_HIGH &gpio2 27 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio2 26 GPIO_ACTIVE_LOW &gpio2 27 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi2>;
        status = "okay";
 };
 
 &ecspi4 {
-       cs-gpios = <&gpio3 29 GPIO_ACTIVE_HIGH &gpio5 2 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio3 29 GPIO_ACTIVE_LOW &gpio5 2 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi4>;
        status = "okay";
index 0930194fd960bab6e358bd0fea043949fb2417ab..4e2a309c93fa8021beac3bf216cad585197119b4 100644 (file)
@@ -94,7 +94,7 @@
 
 /* Colibri SSP */
 &ecspi4 {
-       cs-gpios = <&gpio5 2 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio5 2 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi4>;
        status = "disabled";
index ebe7a8bddf040d599dc71ffceb516606ef9f2d94..648f5fcb72e6545339b18a4288196c64a1a5e87c 100644 (file)
@@ -30,7 +30,7 @@
 };
 
 &ecspi3 {
-       cs-gpios = <&gpio4 24 0>;
+       cs-gpios = <&gpio4 24 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi3>;
        status = "okay";
index 35e230f991f1b2b5b889dd5725c9156941c6458d..7228b894a763f5be5820ab5233ad4c44893f82e2 100644 (file)
 &ecspi2 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi2>;
-       cs-gpios = <&gpio2 26 GPIO_ACTIVE_HIGH>,
-               <&gpio2 27 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio2 26 GPIO_ACTIVE_LOW>,
+               <&gpio2 27 GPIO_ACTIVE_LOW>;
 };
 
 &ecspi4 {
index a46ea98228c209f39a1d4744b697a97ce56f9145..f6182a9d201c866f4609732aec216726a9f8d5ad 100644 (file)
 };
 
 &ecspi3 {
-       cs-gpios = <&gpio4 24 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio4 24 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi3>;
        status = "okay";
index b5f934b8a239e2620f1c62dad4a55840ce9f8e04..55f368e192c0730821e873c8300535e3e43dd0db 100644 (file)
 };
 
 &ecspi2 {
-       cs-gpios = <&gpio2 26 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio2 26 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi2>;
        status = "okay";
index d6b0745975181d1b489ad3fdb70940e52ebd9ead..f68f9dada5b08081495670b8cabbfd88b71780f2 100644 (file)
 };
 
 &ecspi3 {
-       cs-gpios = <&gpio4 24 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio4 24 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi3>;
        status = "okay";
index 11f84ee7b88f6a9c3e616a0745dafc3b824a806b..6c943a517ad76753cc30902f2547b5a75e957354 100644 (file)
 
 
 &ecspi3 {
-       cs-gpios = <&gpio4 24 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio4 24 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi3>;
        status = "okay";
index 0a1ffff9eb750d268d04d0bcecb15fc20425242d..441d8ce97aa4875255890bc10d793f18c4a6c9f9 100644 (file)
 };
 
 &ecspi2 {
-       cs-gpios = <&gpio2 26 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio2 26 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi2>;
        status = "okay";
index e4231331f04e6ebbc9ea0b4b593ffb5bfeb86ee7..eb1ad28946d3652f664c8154c9a71ae3fcc4cb7b 100644 (file)
 &ecspi2 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_hummingboard2_ecspi2>;
-       cs-gpios = <&gpio2 26 0>;
+       cs-gpios = <&gpio2 26 GPIO_ACTIVE_LOW>;
        status = "okay";
 };
 
index 81c7ebb4b3fbe63d010fdabb2b9c9d707c039478..265f5f3dbff62e863996fefb0aedfd9585a61bb6 100644 (file)
 &ecspi2 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi2>;
-       cs-gpios = <&gpio2 26 GPIO_ACTIVE_HIGH>,
-                  <&gpio2 27 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio2 26 GPIO_ACTIVE_LOW>,
+                  <&gpio2 27 GPIO_ACTIVE_LOW>;
 };
 
 /* SPI0 */
 &ecspi4 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi4>;
-       cs-gpios = <&gpio3 24 GPIO_ACTIVE_HIGH>,
-                  <&gpio3 29 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio3 24 GPIO_ACTIVE_LOW>,
+                  <&gpio3 29 GPIO_ACTIVE_LOW>;
        status = "okay";
 
        /* default boot source: workaround #1 for errata ERR006282 */
index 185a1a31ca39945528aa8724ebafbfafbf89bae9..a0917823c244f86234f835ee6a3f25c103f26d7b 100644 (file)
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio3 19 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
        status = "okay";
index 4bbe54e1ddb502f38a203deaa5e494322e819d8b..92d09a3ebe0ee5dcc306ceea265fff4f0dae6261 100644 (file)
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio3 19 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
        status = "okay";
index c63e1bc1ad3a10aef8e6855457b31362850c993d..1243677b5f977fbff9ad7ef59d68fe3dd4cbb1d0 100644 (file)
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio3 19 0>;
+       cs-gpios = <&gpio3 19 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
        status = "okay";
index bc43c75f174504370a5c38c54b0d38cea76f664d..e361df26a168d58639ed576de1070fa872cb0ace 100644 (file)
@@ -71,7 +71,7 @@
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi3>;
        status = "okay";
-       cs-gpios = <&gpio4 24 0>;
+       cs-gpios = <&gpio4 24 GPIO_ACTIVE_LOW>;
 
        som_flash: flash@0 {
                compatible = "m25p80", "jedec,spi-nor";
index 39dfd90c2c6bf6d8bd89a2861a1945b3bcd540d5..5de4ccb979163dd7bc54b26658a3f69571382559 100644 (file)
 &ecspi2 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi2>;
-       cs-gpios = <&gpio2 27 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio2 27 GPIO_ACTIVE_LOW>;
        status = "okay";
 };
 
index 55f736dbee0b5213947d391323ccbd1c17dd52ee..afe477f3298462e1c278dc2a56b4667fee50b7a2 100644 (file)
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio3 19 0>;
+       cs-gpios = <&gpio3 19 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1 &pinctrl_ecspi1_cs>;
        status = "disabled"; /* pin conflict with WEIM NOR */
index 95f9ddab59961be89f5d3a219c0394d8434dc039..fdc3aa9d544d3a98681dc6d9241eecc9752d6214 100644 (file)
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio3 19 0>;
+       cs-gpios = <&gpio3 19 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
        status = "okay";
index 7dddcab9d53ffe01be6751faad1b12e97ac2cc71..f824c9abd11a363e977d1f527d0deac450d8d51c 100644 (file)
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio4 9 0>;
+       cs-gpios = <&gpio4 9 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
        status = "okay";
index 267c956d8910ac16b5384d9d36016fece89cbc93..f88da757edda5a172d82745d5b5c1abb935b7d79 100644 (file)
@@ -95,7 +95,7 @@
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio3 19 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
        status = "okay";
 };
 
 &ecspi2 {
-       cs-gpios = <&gpio6 2 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio6 2 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi2>;
        status = "okay";
index f0be516dc28e1589c454b37a4bf7b74fd96b52c4..e6aa0c33754de834732aaa2d49018a16caf20476 100644 (file)
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio3 19 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
        status = "okay";
 
 &ecspi2 {
        cs-gpios = <
-               &gpio5 31 GPIO_ACTIVE_HIGH
-               &gpio7 12 GPIO_ACTIVE_HIGH
-               &gpio5 18 GPIO_ACTIVE_HIGH
+               &gpio5 31 GPIO_ACTIVE_LOW
+               &gpio7 12 GPIO_ACTIVE_LOW
+               &gpio5 18 GPIO_ACTIVE_LOW
        >;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi2>;
index 5af9ce977b12d46aa9657e70d4ee99a7eefa6e21..66b15748e287381668abb92fab6dd80d96d96a70 100644 (file)
 &ecspi1 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
-       cs-gpios = <&gpio2 30 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio2 30 GPIO_ACTIVE_LOW>;
        status = "okay";
 
        flash@0 {
index b1b069e723d2c13303d659b89ad537544d294ad3..7a3827548cab160dd9d72da11ee0b7ca1426950f 100644 (file)
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio4 11 0>;
+       cs-gpios = <&gpio4 11 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
        status = "okay";
index d25e27d0315f57c9a9f0f64deece9f44d2368ac2..5547916870c7c52fadf395c4a9bed284ed3dd602 100644 (file)
@@ -93,7 +93,7 @@
 &ecspi4 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi4>;
-       cs-gpios = <&gpio7 4 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio7 4 GPIO_ACTIVE_LOW>;
        status = "okay";
 };
 
index a35be2a369b37ee3875ca43de1a6d51a9637ea9d..770f59b23102c23edc66202d2f5cd8285ce59152 100644 (file)
@@ -84,7 +84,7 @@
 };
 
 &ecspi1 {
-       cs-gpios = <&gpio4 26 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio4 26 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
        status = "okay";
index 61ba21a605a81516bf443f939205fc59b66b9766..2a449a3c1ae27a93a613ed37a61b4d4339e871b3 100644 (file)
@@ -14,7 +14,7 @@
 };
 
 &ecspi2 {
-       cs-gpios = <&gpio4 22 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi2>;
        status = "okay";
index 8d5f8dc6ad58cd9e303851261539d03ab740208a..f1513e676c2f96e15aea655ead937b3bbaa9a109 100644 (file)
 &ecspi3 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi3>;
-       cs-gpios = <&gpio1 20 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio1 20 GPIO_ACTIVE_LOW>;
        status = "disabled";
 };
 
index 6cf95939121da82b2c304bd11f4c933da74e0b1b..4436556624d6713c48b438f14b52a6d67bd95c45 100644 (file)
@@ -68,7 +68,7 @@
 
 /* Colibri SPI */
 &ecspi1 {
-       cs-gpios = <&gpio3 26 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio3 26 GPIO_ACTIVE_LOW>;
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1 &pinctrl_ecspi1_cs>;
 };
index e18e89dec879253930743e8ed23c8d0b8002d6ca..62b771c1d5a9a71058dfb478a6f6f14b4641dbaa 100644 (file)
@@ -60,7 +60,7 @@
 &ecspi3 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi3 &pinctrl_ecspi3_cs>;
-       cs-gpios = <&gpio4 11 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio4 11 GPIO_ACTIVE_LOW>;
 };
 
 &fec1 {
index b50b19f2d0f1bb6912d1cc006e28996913fac1db..ac0751bc1177e1544c3c00b9a9073a7e89252d71 100644 (file)
 &ecspi3 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi3>;
-       cs-gpios = <&gpio5 9 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio5 9 GPIO_ACTIVE_LOW>;
        status = "okay";
 
        tsc2046@0 {
index e5e20b07f184b320e3c3e2aea2d9428d81ac1eb6..331b6d259bbaa8d3b5fa4f2a5ccd6e46374a6d34 100644 (file)
@@ -39,7 +39,7 @@
 &ecspi1 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
-       cs-gpios = <&gpio4 19 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio4 19 GPIO_ACTIVE_LOW>;
        status = "okay";
 
        flash@0 {
index cbf0dbb4c198501cfe901c03b463c0963fc3be2d..893bd30aa2a3978a1d27c351d417c53ad955762f 100644 (file)
 &ecspi1 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_ecspi1>;
-       cs-gpios = <&gpio4 19 GPIO_ACTIVE_HIGH>;
+       cs-gpios = <&gpio4 19 GPIO_ACTIVE_LOW>;
        status = "okay";
 
        flash@0 {