]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
net: tulip: delete useless tests on netdev_priv
authorJulia Lawall <Julia.Lawall@lip6.fr>
Thu, 2 Jan 2014 16:28:49 +0000 (17:28 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sat, 4 Jan 2014 00:35:17 +0000 (19:35 -0500)
Netdev_priv performs an addition, not a pointer dereference, so it seems
quite unlikely that its result would ever be NULL.

A semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
statement S;
@@

- if (!netdev_priv(...)) S
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Grant Grundler <grundler@parisc-linux.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/dec/tulip/uli526x.c

index a5397b130724faa9bb4fb9d54881226eb03695bd..aa4ee385091faa850c0ddd9e6f89146be4c401cf 100644 (file)
@@ -1192,9 +1192,6 @@ static int uli526x_suspend(struct pci_dev *pdev, pm_message_t state)
 
        ULI526X_DBUG(0, "uli526x_suspend", 0);
 
-       if (!netdev_priv(dev))
-               return 0;
-
        pci_save_state(pdev);
 
        if (!netif_running(dev))
@@ -1228,9 +1225,6 @@ static int uli526x_resume(struct pci_dev *pdev)
 
        ULI526X_DBUG(0, "uli526x_resume", 0);
 
-       if (!netdev_priv(dev))
-               return 0;
-
        pci_restore_state(pdev);
 
        if (!netif_running(dev))