]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
scsi: ppa: mark expected switch fall-through
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Mon, 26 Nov 2018 20:06:48 +0000 (14:06 -0600)
committerGustavo A. R. Silva <gustavo@embeddedor.com>
Mon, 8 Apr 2019 23:39:04 +0000 (18:39 -0500)
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 114988 ("Missing break in switch")
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
drivers/scsi/ppa.c

index c182b5458f98cb863d049e6354caa18e3f3e16b2..35213082e933bbeb3510a48efab2da7616185fa7 100644 (file)
@@ -717,6 +717,7 @@ static int ppa_engine(ppa_struct *dev, struct scsi_cmnd *cmd)
                        }
                        cmd->SCp.phase++;
                }
+               /* fall through */
 
        case 2:         /* Phase 2 - We are now talking to the scsi bus */
                if (!ppa_select(dev, scmd_id(cmd))) {