]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
net/mlx5e: RX, Remove unnecessary check in RX CQE compression handling
authorTariq Toukan <tariqt@nvidia.com>
Thu, 22 Apr 2021 15:34:57 +0000 (18:34 +0300)
committerSaeed Mahameed <saeedm@nvidia.com>
Thu, 27 May 2021 18:54:36 +0000 (11:54 -0700)
There are two reasons for exiting mlx5e_decompress_cqes_cont():
1. The compression session is completed (cqd.left == 0).
2. The budget is exhausted (work_done == budget).

If after calling mlx5e_decompress_cqes_cont() we have cqd.left > 0,
it necessarily implies that budget is exhausted.

The first part of the complex condition is covered by the second,
hence we remove it here.

Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
drivers/net/ethernet/mellanox/mlx5/core/en_rx.c

index 5346271974f553fbd587cba79f25b872cd255a94..e88429356018720f8728c596fc813fa77fc9fe7f 100644 (file)
@@ -1560,7 +1560,7 @@ int mlx5e_poll_rx_cq(struct mlx5e_cq *cq, int budget)
 
        if (rq->cqd.left) {
                work_done += mlx5e_decompress_cqes_cont(rq, cqwq, 0, budget);
-               if (rq->cqd.left || work_done >= budget)
+               if (work_done >= budget)
                        goto out;
        }