]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
gpio: remove explicit comparison with 0
authorSaiyam Doshi <saiyamdoshi.in@gmail.com>
Sat, 7 Sep 2019 17:39:10 +0000 (23:09 +0530)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 11 Sep 2019 23:05:29 +0000 (00:05 +0100)
No need to compare return value with 0. In case of non-zero
return value, the if condition will be true.

This makes intent a bit more clear to the reader.
"if (x) then", compared to "if (x is not zero) then".

Signed-off-by: Saiyam Doshi <saiyamdoshi.in@gmail.com>
Link: https://lore.kernel.org/r/20190907173910.GA9547@SD
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpiolib.c

index f5b2649e2893a8674e1d7866290db1e141d83923..158e327a1285d60a9324377e46f3c44239e18fb6 100644 (file)
@@ -851,7 +851,7 @@ static irqreturn_t lineevent_irq_thread(int irq, void *p)
        }
 
        ret = kfifo_put(&le->events, ge);
-       if (ret != 0)
+       if (ret)
                wake_up_poll(&le->wait, EPOLLIN);
 
        return IRQ_HANDLED;