]> git.proxmox.com Git - ovs.git/commitdiff
ovsdb-data: Drop redundant initialization from ovsdb_datum_apply_diff().
authorBen Pfaff <blp@ovn.org>
Tue, 25 Sep 2018 04:32:49 +0000 (21:32 -0700)
committerBen Pfaff <blp@ovn.org>
Wed, 26 Sep 2018 20:26:05 +0000 (13:26 -0700)
The call to ovsdb_datum_diff() initializes 'new', so it's not necessary to
also do it in ovsdb_datum_apply_diff().

Found by inspection.

Signed-off-by: Ben Pfaff <blp@ovn.org>
Reviewed-by: Yifeng Sun <pkusunyifeng@gmail.com>
lib/ovsdb-data.c

index 1e523f29cb87c996dc6abf6bdc34d63bae0e9bf6..08b94cafa7370be02c0642bf0dc6be5a55611356 100644 (file)
@@ -2121,7 +2121,6 @@ ovsdb_datum_apply_diff(struct ovsdb_datum *new,
                        const struct ovsdb_datum *diff,
                        const struct ovsdb_type *type)
 {
-    ovsdb_datum_init_empty(new);
     ovsdb_datum_diff(new, old, diff, type);
 
     /* Make sure member size of 'new' conforms to type. */