]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
ASoC: Intel: bytcr_rt5640: align quirk override handling
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Fri, 19 Apr 2019 20:12:17 +0000 (15:12 -0500)
committerMark Brown <broonie@kernel.org>
Thu, 25 Apr 2019 19:23:16 +0000 (20:23 +0100)
As discussed on alsa-devel, a zero value is useful to get rid of all
quirks. Set default to -1 and align types as done in other machine
drivers.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/boards/bytcr_rt5640.c

index f9175cf6747ebb6ee388c8e86a668374b734f594..dc22df9a99fb5fa279046f71a31e6dfc49cbc1f2 100644 (file)
@@ -98,8 +98,8 @@ struct byt_rt5640_private {
 static bool is_bytcr;
 
 static unsigned long byt_rt5640_quirk = BYT_RT5640_MCLK_EN;
-static unsigned int quirk_override;
-module_param_named(quirk, quirk_override, uint, 0444);
+static int quirk_override = -1;
+module_param_named(quirk, quirk_override, int, 0444);
 MODULE_PARM_DESC(quirk, "Board-specific quirk override");
 
 static void log_quirks(struct device *dev)
@@ -1254,7 +1254,7 @@ static int snd_byt_rt5640_mc_probe(struct platform_device *pdev)
        dmi_id = dmi_first_match(byt_rt5640_quirk_table);
        if (dmi_id)
                byt_rt5640_quirk = (unsigned long)dmi_id->driver_data;
-       if (quirk_override) {
+       if (quirk_override != -1) {
                dev_info(&pdev->dev, "Overriding quirk 0x%x => 0x%x\n",
                         (unsigned int)byt_rt5640_quirk, quirk_override);
                byt_rt5640_quirk = quirk_override;