]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
selftests: devlink: fix the fd redirect in dummy_reporter_test
authorJakub Kicinski <kuba@kernel.org>
Thu, 15 Dec 2022 02:01:01 +0000 (18:01 -0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 16 Dec 2022 10:21:36 +0000 (10:21 +0000)
$number + > bash means redirect FD $number, e.g. commonly
used 2> redirects stderr (fd 2). The test uses 8192> to
write the number 8192 to a file, this results in:

  ./devlink.sh: line 499: 8192: Bad file descriptor

Oddly the test also papers over this issue by checking
for failure (expecting an error rather than success)
so it passes, anyway.

Fixes: ff18176ad806 ("selftests: Add a test of large binary to devlink health test")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
tools/testing/selftests/drivers/net/netdevsim/devlink.sh

index 9de1d123f4f5dfd1882e66e56108fc274ffab850..a08c02abde1210ab07b8b8ed6dc7d2ef9607ba18 100755 (executable)
@@ -496,8 +496,8 @@ dummy_reporter_test()
 
        check_reporter_info dummy healthy 3 3 10 true
 
-       echo 8192> $DEBUGFS_DIR/health/binary_len
-       check_fail $? "Failed set dummy reporter binary len to 8192"
+       echo 8192 > $DEBUGFS_DIR/health/binary_len
+       check_err $? "Failed set dummy reporter binary len to 8192"
 
        local dump=$(devlink health dump show $DL_HANDLE reporter dummy -j)
        check_err $? "Failed show dump of dummy reporter"