]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
cpufreq: Clear policy->cpus even for the last CPU
authorViresh Kumar <viresh.kumar@linaro.org>
Thu, 19 Feb 2015 11:32:07 +0000 (17:02 +0530)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 7 May 2015 21:38:35 +0000 (23:38 +0200)
We clear policy->cpus mask while CPUs are hotplugged out. We do it for all CPUs
except the last CPU of the policy. I don't remember what the rationale behind
that was, but I couldn't think of anything that will break if we remove this
conditional clearing and always clear policy->cpus.

The benefit we get out of it is, we can know if a policy is active or not by
checking if this field is empty or not. That will be used by later commits.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Acked-by: Saravana Kannan <skannan@codeaurora.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpufreq/cpufreq.c

index 497935a93614ca47a2b002fce1e691a4a0cb4100..8cf0c0e7aea860dfd2e7eb5c55ae25c3b1efcc01 100644 (file)
@@ -1430,9 +1430,7 @@ static int __cpufreq_remove_dev_finish(struct device *dev,
 
        down_write(&policy->rwsem);
        cpus = cpumask_weight(policy->cpus);
-
-       if (cpus > 1)
-               cpumask_clear_cpu(cpu, policy->cpus);
+       cpumask_clear_cpu(cpu, policy->cpus);
        up_write(&policy->rwsem);
 
        /* If cpu is last user of policy, free policy */