]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
dt: bindings: net: use boolean dt properties for eee broken modes
authorjbrunet <jbrunet@baylibre.com>
Mon, 19 Dec 2016 15:05:38 +0000 (16:05 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 20 Dec 2016 18:50:50 +0000 (13:50 -0500)
The patches regarding eee-broken-modes was merged before all people
involved could find an agreement on the best way to move forward.

While we agreed on having a DT property to mark particular modes as broken,
the value used for eee-broken-modes mapped the phy register in very direct
way. Because of this, the concern is that it could be used to implement
configuration policies instead of describing a broken HW.

In the end, having a boolean property for each mode seems to be preferred
over one bit field value mapping the register (too) directly.

Cc: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Documentation/devicetree/bindings/net/phy.txt
include/dt-bindings/net/mdio.h [deleted file]

index 54749b60a4666adb70514674761fd1031320376b..ff1bc4b1bb3b5e1d91a1747fcc73c24d587cd1a8 100644 (file)
@@ -38,8 +38,14 @@ Optional Properties:
 - enet-phy-lane-swap: If set, indicates the PHY will swap the TX/RX lanes to
   compensate for the board being designed with the lanes swapped.
 
-- eee-broken-modes: Bits to clear in the MDIO_AN_EEE_ADV register to
-  disable EEE broken modes.
+- eee-broken-100tx:
+- eee-broken-1000t:
+- eee-broken-10gt:
+- eee-broken-1000kx:
+- eee-broken-10gkx4:
+- eee-broken-10gkr:
+  Mark the corresponding energy efficient ethernet mode as broken and
+  request the ethernet to stop advertising it.
 
 Example:
 
diff --git a/include/dt-bindings/net/mdio.h b/include/dt-bindings/net/mdio.h
deleted file mode 100644 (file)
index 99c6d90..0000000
+++ /dev/null
@@ -1,19 +0,0 @@
-/*
- * This header provides generic constants for ethernet MDIO bindings
- */
-
-#ifndef _DT_BINDINGS_NET_MDIO_H
-#define _DT_BINDINGS_NET_MDIO_H
-
-/*
- * EEE capability Advertisement
- */
-
-#define MDIO_EEE_100TX         0x0002  /* 100TX EEE cap */
-#define MDIO_EEE_1000T         0x0004  /* 1000T EEE cap */
-#define MDIO_EEE_10GT          0x0008  /* 10GT EEE cap */
-#define MDIO_EEE_1000KX                0x0010  /* 1000KX EEE cap */
-#define MDIO_EEE_10GKX4                0x0020  /* 10G KX4 EEE cap */
-#define MDIO_EEE_10GKR         0x0040  /* 10G KR EEE cap */
-
-#endif