]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
nfsd4: bad BUG() in preprocess_stateid_op
authorJ. Bruce Fields <bfields@redhat.com>
Tue, 17 Aug 2010 22:46:33 +0000 (18:46 -0400)
committerJ. Bruce Fields <bfields@redhat.com>
Thu, 26 Aug 2010 17:20:51 +0000 (13:20 -0400)
It's OK for this function to return without setting filp--we do it in
the special-stateid case.

And there's a legitimate case where we can hit this, since we do permit
reads on write-only stateid's.

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/nfs4state.c

index 0a024917f0528108074f9999e585d616ad95a97b..b990eadb799ced5b00f48b8c01eef310b32146f6 100644 (file)
@@ -2983,7 +2983,6 @@ nfs4_preprocess_stateid_op(struct nfsd4_compound_state *cstate,
                                *filpp = find_readable_file(stp->st_file);
                        else
                                *filpp = find_writeable_file(stp->st_file);
-                       BUG_ON(!*filpp); /* assured by check_openmode */
                }
        }
        status = nfs_ok;