]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
i2c: fix kernel memory disclosure in dev interface
authorVlad Tsyrklevich <vlad@tsyrklevich.net>
Mon, 9 Jan 2017 15:53:36 +0000 (22:53 +0700)
committerWolfram Sang <wsa@the-dreams.de>
Thu, 12 Jan 2017 19:06:10 +0000 (20:06 +0100)
i2c_smbus_xfer() does not always fill an entire block, allowing
kernel stack memory disclosure through the temp variable. Clear
it before it's read to.

Signed-off-by: Vlad Tsyrklevich <vlad@tsyrklevich.net>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Cc: stable@kernel.org
drivers/i2c/i2c-dev.c

index 66f323fd39826ebe9a738d55724ee2e124b45419..6f638bbc922db4fd366e1e3dcdd11c8655215622 100644 (file)
@@ -331,7 +331,7 @@ static noinline int i2cdev_ioctl_smbus(struct i2c_client *client,
                unsigned long arg)
 {
        struct i2c_smbus_ioctl_data data_arg;
-       union i2c_smbus_data temp;
+       union i2c_smbus_data temp = {};
        int datasize, res;
 
        if (copy_from_user(&data_arg,