]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
mailbox: Remove WARN_ON for async_cb.cb in cmdq_exec_done
authorjason-jh.lin <jason-jh.lin@mediatek.com>
Wed, 29 Sep 2021 07:08:07 +0000 (15:08 +0800)
committerAndrea Righi <andrea.righi@canonical.com>
Tue, 7 Dec 2021 06:33:01 +0000 (07:33 +0100)
BugLink: https://bugs.launchpad.net/bugs/1951822
[ Upstream commit ce1537fe288469bf68ee0aabdb860a790b4755ef ]

Because mtk_drm_crtc_update_config is not using cmdq_pkt_flush_async,
it won't have pkt->async_cb.cb anymore.

So remove the WARN_ON check of pkt->async_cb.cb at cmdq_exec_done.

Fixes: 1b6b0ce2240e ("mailbox: mtk-cmdq: Use mailbox rx_callback")
Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com>
Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Tested-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/mailbox/mtk-cmdq-mailbox.c

index 64175a893312e21e572e611dbcac873a29495708..c591dab9d5a48da8957d168ab55726deb89d733f 100644 (file)
@@ -195,7 +195,6 @@ static void cmdq_task_exec_done(struct cmdq_task *task, int sta)
        struct cmdq_task_cb *cb = &task->pkt->async_cb;
        struct cmdq_cb_data data;
 
-       WARN_ON(cb->cb == (cmdq_async_flush_cb)NULL);
        data.sta = sta;
        data.data = cb->data;
        data.pkt = task->pkt;