usb: chipidea: Only read/write OTGSC from one place

BugLink: http://bugs.launchpad.net/bugs/1691418
commit f60f8ccd54e03c1afafb2b20ceb029a0eaf7a134 upstream.

With the id and vbus detection done via extcon we need to make
sure we poll the status of OTGSC properly by considering what the
extcon is saying, and not just what the register is saying. Let's
move this hw_wait_reg() function to the only place it's used and
simplify it for polling the OTGSC register. Then we can make
certain we only use the hw_read_otgsc() API to read OTGSC, which
will make sure we properly handle extcon events.

Acked-by: Peter Chen <peter.chen@nxp.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Ivan T. Ivanov" <iivanov.xz@gmail.com>
Fixes: 3ecb3e09b042 ("usb: chipidea: Use extcon framework for VBUS and ID detect")
Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>
Signed-off-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>

diff --git a/drivers/usb/chipidea/ci.h b/drivers/usb/chipidea/ci.h
index 41d7cf6d63ba32a240add0eaa7c01f63fa8b1f28..858c30814497918afe491e24113a6d7a64c1cc6e 100644 (file)
--- a/drivers/usb/chipidea/ci.h
+++ b/drivers/usb/chipidea/ci.h
@@ -428,9 +428,6 @@ int hw_port_test_set(struct ci_hdrc *ci, u8 mode);
 
 u8 hw_port_test_get(struct ci_hdrc *ci);
 
-int hw_wait_reg(struct ci_hdrc *ci, enum ci_hw_regs reg, u32 mask,
-                               u32 value, unsigned int timeout_ms);
-
 void ci_platform_configure(struct ci_hdrc *ci);
 
 #endif /* __DRIVERS_USB_CHIPIDEA_CI_H */

diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
index ba4a2a1eb3fff95dcb60fd86f0d1fbf38c300f5c..939c6ad7106891689b3c7405f39bea7ae48fae9a 100644 (file)
--- a/drivers/usb/chipidea/core.c
+++ b/drivers/usb/chipidea/core.c
@@ -518,38 +518,6 @@ int hw_device_reset(struct ci_hdrc *ci)
        return 0;
 }
 
-/**
- * hw_wait_reg: wait the register value
- *
- * Sometimes, it needs to wait register value before going on.
- * Eg, when switch to device mode, the vbus value should be lower
- * than OTGSC_BSV before connects to host.
- *
- * @ci: the controller
- * @reg: register index
- * @mask: mast bit
- * @value: the bit value to wait
- * @timeout_ms: timeout in millisecond
- *
- * This function returns an error code if timeout
- */
-int hw_wait_reg(struct ci_hdrc *ci, enum ci_hw_regs reg, u32 mask,
-                               u32 value, unsigned int timeout_ms)
-{
-       unsigned long elapse = jiffies + msecs_to_jiffies(timeout_ms);
-
-       while (hw_read(ci, reg, mask) != value) {
-               if (time_after(jiffies, elapse)) {
-                       dev_err(ci->dev, "timeout waiting for %08x in %d\n",
-                                       mask, reg);
-                       return -ETIMEDOUT;
-               }
-               msleep(20);
-       }
-
-       return 0;
-}
-
 static irqreturn_t ci_irq(int irq, void *data)
 {
        struct ci_hdrc *ci = data;

diff --git a/drivers/usb/chipidea/otg.c b/drivers/usb/chipidea/otg.c
index 03b6743461d15de129a2d7908e851db450111d3c..a829607c3e4df8a4e294d63403bcca2225f2d42a 100644 (file)
--- a/drivers/usb/chipidea/otg.c
+++ b/drivers/usb/chipidea/otg.c
@@ -104,7 +104,31 @@ void ci_handle_vbus_change(struct ci_hdrc *ci)
                usb_gadget_vbus_disconnect(&ci->gadget);
 }
 
-#define CI_VBUS_STABLE_TIMEOUT_MS 5000
+/**
+ * When we switch to device mode, the vbus value should be lower
+ * than OTGSC_BSV before connecting to host.
+ *
+ * @ci: the controller
+ *
+ * This function returns an error code if timeout
+ */
+static int hw_wait_vbus_lower_bsv(struct ci_hdrc *ci)
+{
+       unsigned long elapse = jiffies + msecs_to_jiffies(5000);
+       u32 mask = OTGSC_BSV;
+
+       while (hw_read_otgsc(ci, mask)) {
+               if (time_after(jiffies, elapse)) {
+                       dev_err(ci->dev, "timeout waiting for %08x in OTGSC\n",
+                                       mask);
+                       return -ETIMEDOUT;
+               }
+               msleep(20);
+       }
+
+       return 0;
+}
+
 static void ci_handle_id_switch(struct ci_hdrc *ci)
 {
        enum ci_role role = ci_otg_role(ci);
@@ -116,9 +140,11 @@ static void ci_handle_id_switch(struct ci_hdrc *ci)
                ci_role_stop(ci);
 
                if (role == CI_ROLE_GADGET)
-                       /* wait vbus lower than OTGSC_BSV */
-                       hw_wait_reg(ci, OP_OTGSC, OTGSC_BSV, 0,
-                                       CI_VBUS_STABLE_TIMEOUT_MS);
+                       /*
+                        * wait vbus lower than OTGSC_BSV before connecting
+                        * to host
+                        */
+                       hw_wait_vbus_lower_bsv(ci);
 
                ci_role_start(ci, role);
        }