]> git.proxmox.com Git - mirror_qemu.git/commitdiff
optionrom: cope with multiple -O options
authorPaolo Bonzini <pbonzini@redhat.com>
Tue, 30 Aug 2016 12:30:11 +0000 (14:30 +0200)
committerPaolo Bonzini <pbonzini@redhat.com>
Tue, 30 Aug 2016 14:28:46 +0000 (16:28 +0200)
Reproducer:

    CFLAGS="-g3 -O0" ./configure --target-list=aarch64-softmmu,arm-softmmu --enable-vhost-net --enable-virtfs

Here CFLAGS ends up with "-O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 ... -g3 -O0"
and pc-bios/optionrom/Makefile forgets to add the -O2 it needs.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
pc-bios/optionrom/Makefile

index 9bdc49798c60bf3c77b5d796a6133903b61bf7cd..afa48f1cf1f71b670a83dd9deb8bffb2558c83f1 100644 (file)
@@ -10,10 +10,7 @@ $(call set-vpath, $(SRC_PATH)/pc-bios/optionrom)
 .PHONY : all clean build-all
 
 # Compiling with no optimization creates ROMs that are too large
-ifeq ($(filter -O%, $(CFLAGS)),)
-override CFLAGS += -O2
-endif
-ifeq ($(filter -O%, $(CFLAGS)),-O0)
+ifeq ($(lastword $(filter -O%, -O0 $(CFLAGS))),-O0)
 override CFLAGS += -O2
 endif