]> git.proxmox.com Git - mirror_qemu.git/commitdiff
hw/intc/arm_gicv3_its: Avoid shadowing variable in do_process_its_cmd()
authorPeter Maydell <peter.maydell@linaro.org>
Fri, 22 Sep 2023 15:29:41 +0000 (16:29 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Fri, 29 Sep 2023 08:07:18 +0000 (10:07 +0200)
Avoid shadowing a local variable in do_process_its_cmd():

../../hw/intc/arm_gicv3_its.c:548:17: warning: declaration of ‘ite’ shadows a previous local [-Wshadow=compatible-local]
  548 |         ITEntry ite = {};
      |                 ^~~
../../hw/intc/arm_gicv3_its.c:518:13: note: shadowed declaration is here
  518 |     ITEntry ite;
      |             ^~~

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-ID: <20230922152944.3583438-2-peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
hw/intc/arm_gicv3_its.c

index 5f552b4d37f43c1cacbf8932e6291d66328a6598..52e9aca9c65f0780912549de3ed816ef723c9d8a 100644 (file)
@@ -545,10 +545,10 @@ static ItsCmdResult do_process_its_cmd(GICv3ITSState *s, uint32_t devid,
     }
 
     if (cmdres == CMD_CONTINUE_OK && cmd == DISCARD) {
-        ITEntry ite = {};
+        ITEntry i = {};
         /* remove mapping from interrupt translation table */
-        ite.valid = false;
-        return update_ite(s, eventid, &dte, &ite) ? CMD_CONTINUE_OK : CMD_STALL;
+        i.valid = false;
+        return update_ite(s, eventid, &dte, &i) ? CMD_CONTINUE_OK : CMD_STALL;
     }
     return CMD_CONTINUE_OK;
 }