]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
signal/sparc32: In setup_rt_frame and setup_fram use force_fatal_sig
authorEric W. Biederman <ebiederm@xmission.com>
Wed, 20 Oct 2021 17:44:02 +0000 (12:44 -0500)
committerAndrea Righi <andrea.righi@canonical.com>
Tue, 4 Jan 2022 08:48:55 +0000 (09:48 +0100)
BugLink: https://bugs.launchpad.net/bugs/1952579
commit 086ec444f86660e103de8945d0dcae9b67132ac9 upstream.

Modify the 32bit version of setup_rt_frame and setup_frame to act
similar to the 64bit version of setup_rt_frame and fail with a signal
instead of calling do_exit.

Replacing do_exit(SIGILL) with force_fatal_signal(SIGILL) ensures that
the process will be terminated cleanly when the stack frame is
invalid, instead of just killing off a single thread and leaving the
process is a weird state.

Cc: David Miller <davem@davemloft.net>
Cc: sparclinux@vger.kernel.org
Link: https://lkml.kernel.org/r/20211020174406.17889-16-ebiederm@xmission.com
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Cc: Thomas Backlund <tmb@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
arch/sparc/kernel/signal_32.c

index 02f3ad55dfe3195c39bdfe5941d63d19f4e2a017..cd677bc564a7e279f4f40b2a541749f1d7f5c5f9 100644 (file)
@@ -244,7 +244,7 @@ static int setup_frame(struct ksignal *ksig, struct pt_regs *regs,
                get_sigframe(ksig, regs, sigframe_size);
 
        if (invalid_frame_pointer(sf, sigframe_size)) {
-               do_exit(SIGILL);
+               force_fatal_sig(SIGILL);
                return -EINVAL;
        }
 
@@ -336,7 +336,7 @@ static int setup_rt_frame(struct ksignal *ksig, struct pt_regs *regs,
        sf = (struct rt_signal_frame __user *)
                get_sigframe(ksig, regs, sigframe_size);
        if (invalid_frame_pointer(sf, sigframe_size)) {
-               do_exit(SIGILL);
+               force_fatal_sig(SIGILL);
                return -EINVAL;
        }