]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
wlcore: testmode: use pm_runtime_resume_and_get() instead of pm_runtime_get_sync()
authorMinghao Chi <chi.minghao@zte.com.cn>
Wed, 13 Apr 2022 09:35:02 +0000 (09:35 +0000)
committerKalle Valo <kvalo@kernel.org>
Sat, 23 Apr 2022 07:11:34 +0000 (10:11 +0300)
Using pm_runtime_resume_and_get is more appropriate
for simplifing code

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20220413093502.2538316-1-chi.minghao@zte.com.cn
drivers/net/wireless/ti/wlcore/testmode.c

index 3a17b9a8207e2cb7ad051cfe908d54bd5198112d..3f338b8096c77cc4dd8784f53798f159683cbf5e 100644 (file)
@@ -83,11 +83,9 @@ static int wl1271_tm_cmd_test(struct wl1271 *wl, struct nlattr *tb[])
                goto out;
        }
 
-       ret = pm_runtime_get_sync(wl->dev);
-       if (ret < 0) {
-               pm_runtime_put_noidle(wl->dev);
+       ret = pm_runtime_resume_and_get(wl->dev);
+       if (ret < 0)
                goto out;
-       }
 
        ret = wl1271_cmd_test(wl, buf, buf_len, answer);
        if (ret < 0) {
@@ -158,11 +156,9 @@ static int wl1271_tm_cmd_interrogate(struct wl1271 *wl, struct nlattr *tb[])
                goto out;
        }
 
-       ret = pm_runtime_get_sync(wl->dev);
-       if (ret < 0) {
-               pm_runtime_put_noidle(wl->dev);
+       ret = pm_runtime_resume_and_get(wl->dev);
+       if (ret < 0)
                goto out;
-       }
 
        cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
        if (!cmd) {