]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
ath6kl: fix division by zero in send path
authorJohan Hovold <johan@kernel.org>
Wed, 27 Oct 2021 08:08:18 +0000 (10:08 +0200)
committerAndrea Righi <andrea.righi@canonical.com>
Tue, 4 Jan 2022 08:48:09 +0000 (09:48 +0100)
BugLink: https://bugs.launchpad.net/bugs/1951822
commit c1b9ca365deae667192be9fe24db244919971234 upstream.

Add the missing endpoint max-packet sanity check to probe() to avoid
division by zero in ath10k_usb_hif_tx_sg() in case a malicious device
has broken descriptors (or when doing descriptor fuzz testing).

Note that USB core will reject URBs submitted for endpoints with zero
wMaxPacketSize but that drivers doing packet-size calculations still
need to handle this (cf. commit 2548288b4fb0 ("USB: Fix: Don't skip
endpoint descriptors with maxpacket=0")).

Fixes: 9cbee358687e ("ath6kl: add full USB support")
Cc: stable@vger.kernel.org # 3.5
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20211027080819.6675-3-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/net/wireless/ath/ath6kl/usb.c

index 5372e948e761d2b2f8f373a55a33e9c87969201f..a917092b259ce2d033638b09de744f083c6f049d 100644 (file)
@@ -340,6 +340,11 @@ static int ath6kl_usb_setup_pipe_resources(struct ath6kl_usb *ar_usb)
                                   le16_to_cpu(endpoint->wMaxPacketSize),
                                   endpoint->bInterval);
                }
+
+               /* Ignore broken descriptors. */
+               if (usb_endpoint_maxp(endpoint) == 0)
+                       continue;
+
                urbcount = 0;
 
                pipe_num =