]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
tools build: Fix the zstd test in the test-all.c common case feature test
authorArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 18 Jun 2019 20:59:16 +0000 (17:59 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 18 Jun 2019 21:44:24 +0000 (18:44 -0300)
We were renanimg 'main' to 'main_zstd' but then using 'main_libzstd();'
in the main() for test-all.c, causing this:

  $ cat /tmp/build/perf/feature/test-all.make.output
  test-all.c: In function ‘main’:
  test-all.c:236:2: error: implicit declaration of function ‘main_test_libzstd’; did you mean ‘main_test_zstd’? [-Werror=implicit-function-declaration]
    main_test_libzstd();
    ^~~~~~~~~~~~~~~~~
    main_test_zstd
  cc1: all warnings being treated as errors
  $

I.e. what was supposed to be the fast path feature test was _always_
failing, duh, fix it.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Alexey Budankov <alexey.budankov@linux.intel.com>
Fixes: 3b1c5d965971 ("tools build: Implement libzstd feature check, LIBZSTD_DIR and NO_LIBZSTD defines")
Link: https://lkml.kernel.org/n/tip-ma4abk0utroiw4mwpmvnjlru@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/build/feature/test-all.c

index 3b3d5d72124a544e95d610960631a802d7b2fc06..88145e8cde1a61d65348ab364eb3708000c0f938 100644 (file)
 # include "test-disassembler-four-args.c"
 #undef main
 
-#define main main_test_zstd
+#define main main_test_libzstd
 # include "test-libzstd.c"
 #undef main