]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
rtc: stop warning for invalid alarms when the alarm is disabled
authorAlexandre Belloni <alexandre.belloni@bootlin.com>
Sun, 27 Aug 2023 22:15:31 +0000 (00:15 +0200)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Tue, 5 Sep 2023 23:25:15 +0000 (01:25 +0200)
When the alarm is not enabled, it may never have been set and so we can't
expect it to be valid. This will prevent the apparition of boot messages
like this one:

rtc rtc0: invalid alarm value: 2023-7-8 45:85:85

Link: https://lore.kernel.org/r/20230827221532.543353-1-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/interface.c

index 499d89150afc9a54299a4a8dab7d8aabe60c7847..1b63111cdda2e91b880c5270dbde42c79f1a3b92 100644 (file)
@@ -376,7 +376,7 @@ int __rtc_read_alarm(struct rtc_device *rtc, struct rtc_wkalrm *alarm)
        err = rtc_valid_tm(&alarm->time);
 
 done:
-       if (err)
+       if (err && alarm->enabled)
                dev_warn(&rtc->dev, "invalid alarm value: %ptR\n",
                         &alarm->time);