]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
scsi: qla2xxx: Remove unneeded variable 'rval'
authorJason Yan <yanaijie@huawei.com>
Fri, 11 Sep 2020 09:10:21 +0000 (17:10 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 15 Sep 2020 21:32:01 +0000 (17:32 -0400)
This addresses the following coccinelle warning:

drivers/scsi/qla2xxx/qla_init.c:7112:5-9: Unneeded variable: "rval".
Return "QLA_SUCCESS" on line 7115

Link: https://lore.kernel.org/r/20200911091021.2937708-1-yanaijie@huawei.com
Reported-by: Hulk Robot <hulkci@huawei.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_init.c

index 136010841495578c478437bfcc7fdd3e179b6053..83a541d5b5235e7e8f38e48de760616c40a2835e 100644 (file)
@@ -7119,10 +7119,9 @@ qla24xx_reset_adapter(scsi_qla_host_t *vha)
        unsigned long flags = 0;
        struct qla_hw_data *ha = vha->hw;
        struct device_reg_24xx __iomem *reg = &ha->iobase->isp24;
-       int rval = QLA_SUCCESS;
 
        if (IS_P3P_TYPE(ha))
-               return rval;
+               return QLA_SUCCESS;
 
        vha->flags.online = 0;
        ha->isp_ops->disable_intrs(ha);
@@ -7137,7 +7136,7 @@ qla24xx_reset_adapter(scsi_qla_host_t *vha)
        if (IS_NOPOLLING_TYPE(ha))
                ha->isp_ops->enable_intrs(ha);
 
-       return rval;
+       return QLA_SUCCESS;
 }
 
 /* On sparc systems, obtain port and node WWN from firmware