]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
drm: bridge: dw-hdmi: Constify mode argument to dw_hdmi_phy_ops .init()
authorLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Tue, 26 May 2020 01:14:54 +0000 (04:14 +0300)
committerSam Ravnborg <sam@ravnborg.org>
Tue, 23 Jun 2020 17:56:25 +0000 (19:56 +0200)
The PHY .init() must not modify the mode it receives. Make the pointer
const to enfore that.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20200526011505.31884-17-laurent.pinchart+renesas@ideasonboard.com
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
drivers/gpu/drm/meson/meson_dw_hdmi.c
drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c
include/drm/bridge/dw_hdmi.h

index 23650e69604c6a08ef0ae9016e89c76a87d6124a..6e6a3d95e68e4a40f5ad8f349b71dfca609b2dbd 100644 (file)
@@ -1531,7 +1531,7 @@ static int hdmi_phy_configure(struct dw_hdmi *hdmi)
 }
 
 static int dw_hdmi_phy_init(struct dw_hdmi *hdmi, void *data,
-                           struct drm_display_mode *mode)
+                           const struct drm_display_mode *mode)
 {
        int i, ret;
 
index 71d599970ec799c89708c6182b87f4b0d16c0dd7..757c17fbb29ff4fc7d7f519b091056d1725d7148 100644 (file)
@@ -297,7 +297,7 @@ static inline void dw_hdmi_dwc_write_bits(struct meson_dw_hdmi *dw_hdmi,
 
 /* Setup PHY bandwidth modes */
 static void meson_hdmi_phy_setup_mode(struct meson_dw_hdmi *dw_hdmi,
-                                     struct drm_display_mode *mode)
+                                     const struct drm_display_mode *mode)
 {
        struct meson_drm *priv = dw_hdmi->priv;
        unsigned int pixel_clock = mode->clock;
@@ -427,7 +427,7 @@ static void dw_hdmi_set_vclk(struct meson_dw_hdmi *dw_hdmi,
 }
 
 static int dw_hdmi_phy_init(struct dw_hdmi *hdmi, void *data,
-                           struct drm_display_mode *mode)
+                           const struct drm_display_mode *mode)
 {
        struct meson_dw_hdmi *dw_hdmi = (struct meson_dw_hdmi *)data;
        struct meson_drm *priv = dw_hdmi->priv;
index d286751bb3338368c8ed3231ab20fe43b07d3146..10e210f6455d175c44151821326f4aac7d913853 100644 (file)
@@ -312,7 +312,7 @@ static const struct drm_encoder_helper_funcs dw_hdmi_rockchip_encoder_helper_fun
 };
 
 static int dw_hdmi_rockchip_genphy_init(struct dw_hdmi *dw_hdmi, void *data,
-                            struct drm_display_mode *mode)
+                                       const struct drm_display_mode *mode)
 {
        struct rockchip_hdmi *hdmi = (struct rockchip_hdmi *)data;
 
index 43643ad317306a9afa70039362fcd05fbaba0aaf..8e078cacf06361d998aa782d4ba2a033d7102fb9 100644 (file)
@@ -341,7 +341,7 @@ static int sun8i_hdmi_phy_config_h3(struct dw_hdmi *hdmi,
 }
 
 static int sun8i_hdmi_phy_config(struct dw_hdmi *hdmi, void *data,
-                                struct drm_display_mode *mode)
+                                const struct drm_display_mode *mode)
 {
        struct sun8i_hdmi_phy *phy = (struct sun8i_hdmi_phy *)data;
        u32 val = 0;
index fec293b21c2eed8944af45f82b4bd967922238a7..f930d218cc6bb7fc287bb00b1c8a2cf72b7a84f7 100644 (file)
@@ -114,7 +114,7 @@ struct dw_hdmi_phy_config {
 
 struct dw_hdmi_phy_ops {
        int (*init)(struct dw_hdmi *hdmi, void *data,
-                   struct drm_display_mode *mode);
+                   const struct drm_display_mode *mode);
        void (*disable)(struct dw_hdmi *hdmi, void *data);
        enum drm_connector_status (*read_hpd)(struct dw_hdmi *hdmi, void *data);
        void (*update_hpd)(struct dw_hdmi *hdmi, void *data,